Skip to content

FOUR-7965 add device preview behavior#4935

Merged
danloa merged 2 commits into
summer-2023-3from
feature/FOUR-7965
Jun 28, 2023
Merged

FOUR-7965 add device preview behavior#4935
danloa merged 2 commits into
summer-2023-3from
feature/FOUR-7965

Conversation

@devmiguelangel
Copy link
Copy Markdown
Contributor

@devmiguelangel devmiguelangel commented Jun 28, 2023

Issue & Reproduction Steps

Preview the screen in desktop and mobile resolutions

Solution

Add a desktop and mobile preview button next to the PREVIEW button

How to Test

  1. Switch to feature/FOUR-7965 branch in the projects processmaker and screen-builder
  2. Build the assets
  3. Open the PM Core
  4. Open an existing Screen or create a new one
  5. Press on Preview button
  6. The new device preview buttons must be displayed
  7. Press on mobile preview button
  8. The screen must be displayed in mobile resolution

Related Tickets & Packages

FOUR-7965

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

Created from VS Code using CodeStream

{
id: "button_preview_desktop",
type: "button",
title: this.$t("Preview Desktop"),
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add the translation string to resources/lang/en.json

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be added

{
id: "button_preview_mobile",
type: "button",
title: this.$t("Preview Mobile"),
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add the translation string to resources/lang/en.json

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be added

@devmiguelangel devmiguelangel requested a review from danloa June 28, 2023 15:08
@danloa danloa merged commit 13851bf into summer-2023-3 Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants