Skip to content

FOUR-8828 Process Map refactor#4936

Merged
nolanpro merged 6 commits into
FOUR-8000from
FOUR-8828
Jun 30, 2023
Merged

FOUR-8828 Process Map refactor#4936
nolanpro merged 6 commits into
FOUR-8000from
FOUR-8828

Conversation

@eiresendez
Copy link
Copy Markdown
Contributor

@eiresendez eiresendez commented Jun 28, 2023 •
edited by atlassian Bot
Loading

Issue & Reproduction Steps

As a developer, I want to do a code refactor for Process Map feature to ensure quality and maintainability.

Solution

  • Removed the ModelerReadonly component and use only the Modeler component with read-only flag.
    • The Modeler component is now able to "hide sections" like the ModelerReadonly did.
  • Make sure that Modeler (read-only) works with the AI team's work.
  • The color of the sequence flows has been fixed when they have been traversed at least once.
  • Full names are now used instead of usernames in the Tooltip.
  • The appropriate permission is now used when accessing the route that loads the Inflight ProcessMap.
  • Added adaptations to ensure that the AI team doesn't encounter any issues when using the ProcessMap.
  • The colors have been updated according to the feedback provided by the design team.

How to Test

  • Please perform manual testing in the QA server.

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:deploy
ci:modeler:FOUR-8828

@eiresendez eiresendez mentioned this pull request Jun 28, 2023
Merged
@pmkerberos
Copy link
Copy Markdown

pmkerberos commented Jun 28, 2023

QA server was successfully deployed https://ci-aa7fdea90d.eng.processmaker.net

1 similar comment
@pmkerberos
Copy link
Copy Markdown

pmkerberos commented Jun 28, 2023

QA server was successfully deployed https://ci-aa7fdea90d.eng.processmaker.net

@gustavobascope @eiresendez
FOUR-9127 In-Flight Process Map has an incorrect permission (#4934)
6650c9d 
* change the permission to view all requests

* FOUR-8947 change the user's first name and last name instead of username

* fix a data type console error

* Use fullname attribute instead

* Make request param optional

---------

Co-authored-by: Eleazar Resendez <eleazar.resendez@processmaker.com>
@pmkerberos
Copy link
Copy Markdown

pmkerberos commented Jun 28, 2023

QA server was successfully deployed https://ci-aa7fdea90d.eng.processmaker.net

@eiresendez eiresendez requested a review from nolanpro June 30, 2023 17:37
@nolanpro nolanpro merged commit 70746f1 into FOUR-8000 Jun 30, 2023
@eiresendez eiresendez mentioned this pull request Jul 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nolanpro nolanpro nolanpro approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@eiresendez @pmkerberos @nolanpro @gustavobascope