Skip to content

PM Block: Import/Export [FOUR-7372]#4981

Merged
ryancooley merged 11 commits into
developfrom
feature/FOUR-7372
Jul 14, 2023
Merged

PM Block: Import/Export [FOUR-7372]#4981
ryancooley merged 11 commits into
developfrom
feature/FOUR-7372

Conversation

@sanjacornelius
Copy link
Copy Markdown
Contributor

@sanjacornelius sanjacornelius commented Jul 11, 2023

This PR introduces crucial import/export functionality to PM Blocks, enhancing their versatility and usability. It includes the following key changes:

  • Updated the incrementStringSeparator variable to handle duplicate items as an array. This enhancement allows for specifying specific string separators for each duplicated attribute. For instance, the 'name' attribute can be separated by a space (" "), while the process_package_key attribute can be separated by a dash ("-").
public $handleDuplicatesByIncrementing = ['name', 'process_package_key'];
public $incrementStringSeparator = [' ', '-'];
  • Implemented the hiding of assets from the UI based on the asset_type column.
  • Applied PHP CS FIXER formatting for improved code consistency and readability.

##To Test

  1. Create a PM block.
  2. Export the PM block from the PM Block listing page.
  3. Import the PM block.
  4. Verify that the PM block is listed under the PM Block pages.
  5. Confirm that any assets attached to the PM block are not displayed within the UI.
  6. Ensure the ability to edit the PM block.
  7. Run the PM block in a process to validate its functionality.

Related Tickets & Packages

  • PM blocks Epic FOUR-7365

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@sanjacornelius sanjacornelius marked this pull request as draft July 11, 2023 17:35
@processmaker-sonarqube
Copy link
Copy Markdown

@sanjacornelius sanjacornelius marked this pull request as ready for review July 14, 2023 17:35
@sanjacornelius sanjacornelius changed the title WIP: PM Block: Import/Export [FOUR-7372] PM Block: Import/Export [FOUR-7372] Jul 14, 2023
@mcraeteisha mcraeteisha self-requested a review July 14, 2023 17:38
@ryancooley ryancooley merged commit 75cfcc1 into develop Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants