Skip to content

FOUR-9268: QA observations#4982

Merged
pmPaulis merged 3 commits into
feature/FOUR-8121from
feature/FOUR-9268
Jul 13, 2023
Merged

FOUR-9268: QA observations#4982
pmPaulis merged 3 commits into
feature/FOUR-8121from
feature/FOUR-9268

Conversation

@pmPaulis
Copy link
Copy Markdown
Contributor

Issue & Reproduction Steps

Describe the issue this ticket solves and describe how to reproduce the issue (please attach any fixtures used to reproduce the issue).

Solution

  • List the changes you've introduced to solve the issue.

How to Test

Describe how to test that this solution works.

Related Tickets & Packages

  • Link to any related FOUR tickets, PRDs, or packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@pmPaulis pmPaulis force-pushed the feature/FOUR-9268 branch 5 times, most recently from 89efa01 to 5cee207 Compare July 12, 2023 12:42
@pmPaulis pmPaulis changed the title FOUR-9268 FOUR-9268: QA observations Jul 12, 2023
@pmPaulis pmPaulis force-pushed the feature/FOUR-9268 branch 4 times, most recently from 4894fc9 to 5ad622e Compare July 12, 2023 20:24
@pmPaulis pmPaulis force-pushed the feature/FOUR-9268 branch from 5ad622e to e02550f Compare July 13, 2023 12:46
@pmPaulis pmPaulis force-pushed the feature/FOUR-9268 branch from a8d7120 to 1435bec Compare July 13, 2023 15:35
@processmaker-sonarqube
Copy link
Copy Markdown

SonarQube Quality Gate

Quality Gate failed

Failed condition 0.0% 0.0% Coverage on New Code (is less than 80%)

See analysis details on SonarQube

@pmPaulis pmPaulis merged commit 86f4c0c into feature/FOUR-8121 Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant