FOUR-9229 Review email-connect, to avoid the launch of a docker instance to send an simple email#4991
Conversation
|
SonarQube Quality Gate
|
| $token->setProperty('error', $error); | ||
|
|
||
| // Log message errors | ||
| error_log('Service task failed: ' . $implementation . ' - ' . $exception->getMessage()); |
Contributor
There was a problem hiding this comment.
please remove this line, in the next line is logged the same error...
| use ProcessMaker\Models\EnvironmentVariable; | ||
| use ProcessMaker\Models\Process as Definitions; | ||
| use ProcessMaker\Models\Process; | ||
| use ProcessMaker\Models\Process as Definitions; |
Contributor
There was a problem hiding this comment.
this reference is not used in this file...
Contributor
Author
There was a problem hiding this comment.
Definitions is used as alias of Process. I removed the use ProcessMaker\Models\Process; and use Definitions to keep the logic of the class
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue & Reproduction Steps
Bring up a docker ssr to render a html template is a bit overkill, so as a developer I want to use a simple php renderer with mustache and date time format support.
Expected behavior:
Add HtmlRenderer class with mustache and date format
Solution
How to Test
Test_EmailConnector.zip
Related Tickets & Packages
Code Review Checklist