Skip to content

FOUR-8942: When Creating a Process with Bpmn and Super Admin as Process Manager, Registry is Wrong #4994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pmPaulis merged 1 commit into from
Jul 13, 2023
Merged

FOUR-8942: When Creating a Process with Bpmn and Super Admin as Process Manager, Registry is Wrong #4994

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ProcessMaker/Events/ProcessCreated.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ class ProcessCreated implements SecurityLogEventInterface

public const TEMPLATE_CREATION = 'TEMPLATE';

public const BPMN_CREATION = 'BPMN';

/**
* Create a new event instance.
*
Expand Down
5 changes: 3 additions & 2 deletions ProcessMaker/Http/Controllers/Api/ProcessController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ public function store(Request $request)
{
$request->validate(Process::rules());
$data = $request->all();

$processCreated = ProcessCreated::BLANK_CREATION;
// If bpmn exists (from Generative AI)
if ($request->input('bpmn')) {
$data['bpmn'] = $request->input('bpmn');
Expand All @@ -236,6 +236,7 @@ public function store(Request $request)
$request->request->add(['bpmn' => $data['bpmn']]);
$request->request->remove('file');
unset($data['file']);
$processCreated = ProcessCreated::BPMN_CREATION;
}

if ($schemaErrors = $this->validateBpmn($request)) {
Expand Down Expand Up @@ -278,7 +279,7 @@ public function store(Request $request)
);
}
// Register the Event
ProcessCreated::dispatch($process->refresh(), ProcessCreated::BLANK_CREATION);
ProcessCreated::dispatch($process->refresh(), $processCreated);

return new Resource($process->refresh());
}
Expand Down