FOUR-9362 Log error and continue running if settings are not set#5029
Merged
Conversation
gproly
approved these changes
Jul 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Issue & Reproduction Steps
A process errors when run and some settings are not set for scripts and data sources
Solution
Continue running a process if some script or data connector settings are not set. Log the error in the data object
How to Test
Create a process and drag a script and data connector node onto the canvas. Do not configure the nodes. Connect them and run the process. The process should complete without errors.
Related Tickets & Packages
Code Review Checklist
ci:package-data-sources:feature/FOUR-9362