Skip to content

FOUR-9412 Fix retry script task#5039

Merged
ryancooley merged 4 commits into
developfrom
FOUR-9412
Jul 21, 2023
Merged

FOUR-9412 Fix retry script task#5039
ryancooley merged 4 commits into
developfrom
FOUR-9412

Conversation

@caleeli
Copy link
Copy Markdown
Contributor

@caleeli caleeli commented Jul 20, 2023

Issue & Reproduction Steps

During the retry test, a failed script task that was not fixed, changed the process state to ACTIVE when the user pressed "RETRY" instead of remaining in ERROR as intended.

Solution

  • Change to ACTIVE only when the script task is completed successfully.

How to Test

  • Create a script task with a throw exception
  • Add the script to a process
  • Run the process
  • The task fails, then try RETRY, the request should keep in ERROR status
  • Fix the script
  • try RETRY again
  • The request should continue (to ACTIVE if there is a next task or COMPLETED if it is the last)

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@caleeli caleeli requested a review from julceslauhub July 20, 2023 20:10
Copy link
Copy Markdown
Contributor

@julceslauhub julceslauhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Copy link
Copy Markdown
Contributor

@julceslauhub julceslauhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@processmaker-sonarqube
Copy link
Copy Markdown

@julceslauhub julceslauhub changed the title Fix retry script task FOUR-9412 Fix retry script task Jul 21, 2023
@ryancooley ryancooley merged commit 303d750 into develop Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants