Skip to content

Test route cache to check duplicated routes#5052

Merged
ryancooley merged 6 commits into
developfrom
bugfix/FOUR-9334
Aug 4, 2023
Merged

Test route cache to check duplicated routes#5052
ryancooley merged 6 commits into
developfrom
bugfix/FOUR-9334

Conversation

@caleeli
Copy link
Copy Markdown
Contributor

@caleeli caleeli commented Jul 24, 2023

Issue & Reproduction Steps

There is no check to validate if there are duplicated route names.

Solution

  • Add a test to check if there are duplicated route names.
  • Ignore the routes without name because they don't block the route:cache

How to Test

  • Run the test DuplicatedRoutesTest.
  • To chek if it fails create a duplicated route in the code and run the test.

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@caleeli caleeli requested review from nolanpro and removed request for nolanpro August 4, 2023 13:35
@ryancooley ryancooley merged commit 12446a4 into develop Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants