Fix symfony console error suppression for CI#5058
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Errors in the console must have an exit status > 0 for CI to see it as an error. This PR prevents the symfony console from handling the error and returning an exit status of 0, which it does by default surprisingly:
This commit broke phpunit but it was not reported as an error becuase of the wrong exit code:
https://github.com/ProcessMaker/package-data-sources/commit/89f397e3ee9ff83ab6692833a3a173e8ab16a54e#diff-7852460389a4904107d9e1398a9f028c8a75c752003f3ee7e679b002c1a005d4
CI Log:
https://github.com/ProcessMaker/processmaker/actions/runs/5625884182/job/15245970370
The error above was fixed here https://github.com/ProcessMaker/package-data-sources/pull/304 but this PR is needed to catch future issues
Data Connector Fixes:
ci:package-data-sources:bugfix/FOUR-9657
Security Log Fixes:
ci:package-dynamic-ui:bugfix/FOUR-9671
ci:package-pm-blocks:bugfix/FOUR-9671
ci:package-savedsearch:bugfix/FOUR-9671