Bugfix/four 9664#5066
Merged
Merged
Conversation
nolanpro
requested changes
Aug 1, 2023
| } | ||
|
|
||
| if($user->can('participate', $media->model)) { | ||
| return $user->can('participate', $media->model); |
Contributor
There was a problem hiding this comment.
@gustavobascope For this and the one above it, inside the conditional you can return true; instead of running the permission check again
nolanpro
approved these changes
Aug 1, 2023
gproly
approved these changes
Aug 1, 2023
Merge branch 'develop' into bugfix/FOUR-9664
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue & Reproduction Steps
Request failed with status code 403" Error when delete files
Solution
Added a policy for request if a user participate
How to Test
Create a process
Add a screen with file upload
Complete task A with the admin user
Send the request to task B
Complete task B with the user without permissions
Upload files with the user without permissions
Try to delete the file uploaded
Related Tickets & Packages
https://processmaker.atlassian.net/browse/FOUR-9664