Skip to content

Do not consider null values duplicates when importing#5070

Merged
ryancooley merged 2 commits into
developfrom
bugfix/FOUR-9646
Aug 1, 2023
Merged

Do not consider null values duplicates when importing#5070
ryancooley merged 2 commits into
developfrom
bugfix/FOUR-9646

Conversation

@nolanpro
Copy link
Copy Markdown
Contributor

@nolanpro nolanpro commented Jul 31, 2023

Issue & Reproduction Steps

Required for https://github.com/ProcessMaker/package-data-sources/pull/307

Occasionally we need to temporarily set a foreign key to null until all the models are saved and we have a new key for it. To support this, we should not consider null values duplicates.

Solution

  • Skip checking duplicates if the value is null

How to Test

  • See jira issue

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:package-data-sources:bugfix/FOUR-9646

Copy link
Copy Markdown
Contributor

@agustinbusso agustinbusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix is correct, the PM block can be created and assigned correctly:

Screen.Recording.2023-08-01.at.08.46.29.mov
Screen.Recording.2023-08-01.at.08.47.46.mov
Screen.Recording.2023-08-01.at.08.48.29.mov

@ryancooley ryancooley merged commit de4c222 into develop Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants