Do not consider null values duplicates when importing#5070
Merged
Conversation
agustinbusso
approved these changes
Aug 1, 2023
Contributor
agustinbusso
left a comment
There was a problem hiding this comment.
The fix is correct, the PM block can be created and assigned correctly:
Screen.Recording.2023-08-01.at.08.46.29.mov
Screen.Recording.2023-08-01.at.08.47.46.mov
Screen.Recording.2023-08-01.at.08.48.29.mov
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue & Reproduction Steps
Required for https://github.com/ProcessMaker/package-data-sources/pull/307
Occasionally we need to temporarily set a foreign key to null until all the models are saved and we have a new key for it. To support this, we should not consider null values duplicates.
Solution
How to Test
Related Tickets & Packages
Code Review Checklist
ci:package-data-sources:bugfix/FOUR-9646