Fix PM Block Export/Import with Data Source Scripts and Collections#5077
Merged
Conversation
|
QA server was successfully deployed https://ci-aa660a5ddf.eng.processmaker.net |
2 similar comments
|
QA server was successfully deployed https://ci-aa660a5ddf.eng.processmaker.net |
|
QA server was successfully deployed https://ci-aa660a5ddf.eng.processmaker.net |
agustinbusso
approved these changes
Aug 3, 2023
Contributor
agustinbusso
left a comment
There was a problem hiding this comment.
The fix is correct:
Screen.Recording.2023-08-03.at.10.30.59.mov
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue & Reproduction Steps
This pull request (PR) addresses a critical issue related to exporting and importing script tasks with webhooks enabled when they are referenced in the
data_source_scripts table. The previous error was hindering the proper export and import of PM Blocks that utilize a data source script into an instance. With this PR, we have introduced a comprehensive solution that allows for seamless import of the data source script, generating a new ID, and updating the BPMN scriptRef ID to reflect the newly generated ID.Additionally, as part of this solution, we have created separate PRs for both Data Sources and the Collections package to ensure smooth handling of script dependencies and proper UUID generation during the export/import process.
Key Changes and Improvements:
How to Test
Import this process into your instance.
Process_ with Data Connectors.json.txt
Save the process as a PM Block.
Export the PM Block.
Reimport the PM Block.
Expected Behavior
Related Tickets & Packages
ci:package-collections:observation/FOUR-9383
ci:package-data-sources:observation/FOUR-9383
ci:deploy
Code Review Checklist