Skip to content

Refactor associateNestedScreen to include loops#5078

Merged
ryancooley merged 3 commits into
developfrom
bugfix/FOUR-9641
Aug 2, 2023
Merged

Refactor associateNestedScreen to include loops#5078
ryancooley merged 3 commits into
developfrom
bugfix/FOUR-9641

Conversation

@nolanpro
Copy link
Copy Markdown
Contributor

@nolanpro nolanpro commented Aug 2, 2023

Issue & Reproduction Steps

See Jira issue. Nested screens in loops are being exported but are not being re-associated to the correct ID when importing.

Solution

  • Refactor the logic to include loops when looking for nested screens to re-associate.
  • Bonus performance update by using an old-to-new ID map so we don't iterate the entire config for every nested screen.

How to Test

Follow reproduction steps in Jira issue. Nested screens should correctly associate to the new screens

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@nolanpro nolanpro requested a review from agustinbusso August 2, 2023 00:43
@nolanpro nolanpro requested review from marcoAntonioNina and removed request for agustinbusso August 2, 2023 16:44
@ryancooley ryancooley merged commit 7c267bd into develop Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants