Skip to content

Bugfix/FOUR-9727: Non-system assets are being hidden from the UI as if they were system assets#5081

Merged
ryancooley merged 4 commits into
developfrom
bugfix/FOUR-9727
Aug 3, 2023
Merged

Bugfix/FOUR-9727: Non-system assets are being hidden from the UI as if they were system assets#5081
ryancooley merged 4 commits into
developfrom
bugfix/FOUR-9727

Conversation

@agustinbusso
Copy link
Copy Markdown
Contributor

@agustinbusso agustinbusso commented Aug 2, 2023

Issue & Reproduction Steps

Please see to the ticket https://processmaker.atlassian.net/browse/FOUR-9727

Solution

  • Update the scopeNonSystem function to look at category_assignments to make sure the asset does not belong to a system category.

Working video

Screen.Recording.2023-08-02.at.10.19.35.mov

How to Test

Test 1

  • Import the attached process in the ticket
  • Go to scripts and verify that the script is showing in the list

Test 2

  • In category_assignments table, modify the category_id to point to a system category (you need to go to script_categories table and modify some script category to be is_system = 1)
  • Go back to scripts, and the script using the system category should not show

Test 3

  • Test the same as test 2 but with processes
  • Test the same as test 2 but with screens
  • Test the same as test 2 but with data sources

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

Comment thread ProcessMaker/Traits/HideSystemResources.php
@eiresendez eiresendez self-requested a review August 2, 2023 19:12
Copy link
Copy Markdown
Contributor

@eiresendez eiresendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved! Tested for scripts, screens, processes and data sources, both manually and with packages that installed resources by default.

Comment thread upgrades/2023_08_02_168972_add_default_screens_to_system_category.php Outdated
@agustinbusso agustinbusso requested a review from eiresendez August 3, 2023 14:00
@ryancooley ryancooley merged commit f31eda9 into develop Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants