Skip to content

FOUR-9739: Fix error handling#5084

Merged
ryancooley merged 1 commit into
developfrom
bugfix/FOUR-9739
Aug 3, 2023
Merged

FOUR-9739: Fix error handling#5084
ryancooley merged 1 commit into
developfrom
bugfix/FOUR-9739

Conversation

@caleeli
Copy link
Copy Markdown
Contributor

@caleeli caleeli commented Aug 2, 2023

Issue & Reproduction Steps

A process stops when a service task fails at https://nightly-qa.processmaker.net/.

Steps to reproduces:

  1. Create a decision table with invalid rules
  2. Create a process that calls to the decision table (See the attached process)
  3. Run the process
  4. When the process runs the invalid decision table will stop to process.

Expected behavior:
Show the error response from the task

Solution

  • Fix the code where the error is handled.

How to Test

  1. Create a decision table with invalid rules
  2. Create a process that calls to the decision table (See the attached process)
  3. Run the process
  4. When the process runs the invalid decision table will stop to process.
    Test_OR AND.zip

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:deploy

@caleeli caleeli requested a review from nolanpro August 2, 2023 19:44
@tokensPM
Copy link
Copy Markdown

tokensPM commented Aug 2, 2023

QA server was successfully deployed https://ci-c6e5129649.eng.processmaker.net

Copy link
Copy Markdown
Contributor

@nolanpro nolanpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to reproduce using an invalid data connector and this fix works as expected

@ryancooley ryancooley merged commit 5acafbe into develop Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants