Skip to content

FOUR-9666: Inconsistent top menu highlighting#5092

Merged
ryancooley merged 2 commits into
developfrom
bugfix/FOUR-9666-feature
Aug 4, 2023
Merged

FOUR-9666: Inconsistent top menu highlighting#5092
ryancooley merged 2 commits into
developfrom
bugfix/FOUR-9666-feature

Conversation

@pmPaulis
Copy link
Copy Markdown
Contributor

@pmPaulis pmPaulis commented Aug 3, 2023

Issue & Reproduction Steps

  • Enable the Analytics package
  • Check all the principal menus
  • We can see some highlighting issues

Solution

  • I extended the Menu Class in order to provide a way to add a Menu in the topnav like the following example:
    $topnav->add(__('Analytics'), [ 'route' => 'package.analytics.tab.index', 'id' => 'analytics', 'afterItem' => 'requests', 'index' => '2', ])->active('package-analytics-reporting/*');

How to Test

Enable the package-analytics-reporting this will enable a menu in the topnav
Edit-Users-ProcessMaker(7)
Completed-Requests-ProcessMaker
Completed-Tasks-ProcessMaker
![Screenshot from 2023-08-04 14-46-16](https://github.com/ProcessMaker/processmaker/assets/42388723/c8ba6ce7-192f-4
Screenshot from 2023-08-04 14-46-23
010-b525-cf18050d35ac)

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

Comment thread ProcessMaker/Providers/ProcessMakerServiceProvider.php
Comment thread ProcessMaker/Managers/MenuBuilder.php
Comment thread ProcessMaker/Managers/MenuManager.php
Comment thread resources/views/layouts/navbar.blade.php Outdated
@pmPaulis pmPaulis force-pushed the bugfix/FOUR-9666-feature branch from 07471a5 to b66086d Compare August 4, 2023 21:07
@pmPaulis pmPaulis force-pushed the bugfix/FOUR-9666-feature branch from a4d8763 to 9ad1cf5 Compare August 4, 2023 21:21
@ryancooley ryancooley merged commit 7894676 into develop Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants