Remove dependent assignment when not on target instance#5099
Merged
Conversation
marcoAntonioNina
approved these changes
Aug 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue & Reproduction Steps
See description in Jira issue
If we export a process with a script, the script will have a "Run script as" user assigned. Users are not exported. When we import the process, the system searches for a user with the same UUID, email, or username. If found, it sets the "Run script as" user to that user. However, if the user is not found in the target instance, it does not change the "Run script as" user id. This could create a problem if the source instance had a Run script as user: bob with the id 5 and the target instance does not have bob, but does have the user alice and happens to have the same ID: 5. When the script imports, since it does not change the "Run script as" user id, the script will be accidentally assigned to alice My suggestion is that we set the "Run script as" user to null if the user does not exist in the target instance
Solution
How to Test
Undefined array key "assign_to"if the user did not exist, or, if a different user exists with the same ID, it would wrongfully be assigned to that user.Related Tickets & Packages
Code Review Checklist