Skip to content

Bugfix/FOUR-9798: Cannot create a process if it is added and then clears the Process Manager field#5111

Merged
ryancooley merged 1 commit into
developfrom
bugfix/FOUR-9798
Aug 8, 2023
Merged

Bugfix/FOUR-9798: Cannot create a process if it is added and then clears the Process Manager field#5111
ryancooley merged 1 commit into
developfrom
bugfix/FOUR-9798

Conversation

@agustinbusso
Copy link
Copy Markdown
Contributor

@agustinbusso agustinbusso commented Aug 8, 2023

Issue & Reproduction Steps

Steps to reproduced:

1.Go to designer
2.Click on +Process
3.Complete Name
4.Complete Description
5.Add Process Manager
6.Remove Process Manager
7. Click on Save button

Current Behavior:
The process cannot be created, the save button is blocked and a message is displayed in the console "Cannot read properties of null".

Expected Behavior:
You should be able to create a process without problem.

Solution

  • Set manager to empty string instead to null when changing the value.

Working video

Screen.Recording.2023-08-08.at.15.19.21.mov

How to Test

  • Follow steps above

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@eiresendez eiresendez self-requested a review August 8, 2023 19:14
Copy link
Copy Markdown
Contributor

@eiresendez eiresendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The process can be stored with or without a manager and when the manager field has been deselected

@ryancooley ryancooley merged commit 6e2491e into develop Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants