Skip to content

Conversation

@nolanpro
Copy link
Contributor

Issue & Reproduction Steps

Backporting the hotfixes enabled Soketi but broke Pusher. We need to support all 3 broadcasting services:

  • Laravel Echo Server (local development)
  • Pusher (CICD)
  • Soketi (k8s)

Solution

  • Update config to support all 3

How to Test

  • Laravel Echo Server
    • run npx laravel-echo-server start if its not already running
    • Set .env
      BROADCAST_DRIVER=redis
      
  • Pusher
    • Create a pusher account and add to your .env
      BROADCAST_DRIVER=pusher
      PUSHER_APP_ID=947781
      PUSHER_APP_KEY=<key>
      PUSHER_APP_SECRET=<secret>
      PUSHER_CLUSTER=<cluster>
      PUSHER_TLS=FALSE
      PUSHER_DEBUG=FALSE
      
  • Soketi
    • run docker run -p 6001:6001 -p 9601:9601 quay.io/soketi/soketi:1.4-16-debian
    • .env
      BROADCAST_DRIVER=pusher
      PUSHER_HOST=127.0.0.1
      

NOTE: BROADCAST_DRIVER is pusher for both Pusher and Soketi. Having PUSHER_HOST is what enables Soketi

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@nolanpro nolanpro requested a review from agustinbusso August 14, 2023 19:00
@ryancooley ryancooley merged commit a1f32ad into develop Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants