-
Notifications
You must be signed in to change notification settings - Fork 241
Task/FOUR-27119: Modify Task Edit to render iframe with smart extract URL after Operator clicks on HITL Manual Task #8582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
You have run out of free Bugbot PR reviews for this billing cycle. This will reset on November 21. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
8fa02f4 to
1588be9
Compare
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 21968551 | Triggered | Generic High Entropy Secret | 1588be9 | ProcessMaker/Http/Controllers/TaskController.php | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
|
The URL exposing the document has been removed from the codebase, but it still exists in the Git history since the commit containing it was already pushed. The document in question is a dummy file and does not contain any sensitive information. We can proceed with the PR and we’ll ensure to handle such cases more carefully in future commits. |
7d47ac7 to
19596cd
Compare
|
|
Thanks @eiresendez You're absolutely right, the oversight was mine, and I apologize for the error. Thank you for pointing it out and for the correction. To prevent the URL data from being exposed, even if it's dummy data, I've redone the pull request with clean commits, removing the URL information with dummy data. |
Observation was fixed |




Solution
TASK edit.blade.php file was modified to include an iframe to render Smart Extract Portal for Human in the loop process
Related Ticket