FOUR-31336 | Change on clients adding modal for plainSecret#8835
Merged
Conversation
nolanpro
requested changes
May 19, 2026
Contributor
nolanpro
left a comment
There was a problem hiding this comment.
@AugustoLopezProcess when I edit and save an existing client, it still shows the warning but without the secret. It shouldn't show the popup when editing an existing client.
Contributor
Author
AugustoLopezProcess
left a comment
There was a problem hiding this comment.
Preventing now that the modal shows on edit, and refresh listing of clients if edit
|
nolanpro
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





Issue & Reproduction Steps
Upgrading Laravel Passport stores OAuth client secrets as hashed values only. The plain-text secret is available once at creation via
$client->plainSecretand is not persisted in a readable form.Before this change:
/admin/auth-clients).Expected: Users must see and save the plain-text secret only at creation time, consistent with Passport’s one-time
plainSecretbehavior.Solution
AuthClientAPI resource — Returnsecretfrom$this->plainSecretinstead of$this->secret, so create responses include the one-time plain-text value while list/show responses do not expose a readable secret.ClientController— Remove$client->makeVisible('secret')after store; it is no longer needed with hashed secrets.AuthClientsListing.vue) — Remove the Client Secret column, its copy-to-clipboard slot, and related styles/helpers.index.blade.php) — After a successful create/save, open a Secret modal with:response.data.secretHow to Test
/admin/auth-clients.secret; after creation, list/edit should not reveal a readable secret).POST /oauth/clients→ response includessecret(plain text) on create.GET /oauth/clients→ items do not include a usable plain-textsecret.Related Tickets & Packages
plainSecret).Code Review Checklist