Skip to content

Improve error message when Node.js < 18 #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shirish-goyal wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve error message when Node.js < 18 #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 27 additions & 2 deletions packages/cli/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -696,7 +696,19 @@ program
checks.push({ name: 'node_version', status: 'pass', message: `v${nodeVersion}` });
passed++;
} else {
fmt.error(`Node.js: v${nodeVersion} — requires >= 18`, 'Download from nodejs.org');
const msg = `
Node.js v${nodeVersion} detected — Cortex requires Node.js 18 or later

How to upgrade:
macOS: brew install node@22
Linux: curl -fsSL https://deb.nodesource.com/setup_22.x | sudo -E bash - && sudo apt install -y nodejs
Windows: Download from https://nodejs.org/en/download
nvm: nvm install 22 && nvm use 22

Current: v${nodeVersion}
Required: >= 18.0.0
`;
fmt.error(msg.trim());
checks.push({ name: 'node_version', status: 'fail', message: `v${nodeVersion} — requires >= 18` });
failed++;
}
Expand Down Expand Up @@ -1426,7 +1438,20 @@ program
// Step 1: Check Node version
const major = parseInt(process.versions.node.split('.')[0], 10);
if (major < 18) {
fmt.error(`Node.js v${process.versions.node} — requires >= 18`, 'Download from nodejs.org');
const nodeVersion = process.versions.node;
const msg = `
Node.js v${nodeVersion} detected — Cortex requires Node.js 18 or later

How to upgrade:
macOS: brew install node@22
Linux: curl -fsSL https://deb.nodesource.com/setup_22.x | sudo -E bash - && sudo apt install -y nodejs
Windows: Download from https://nodejs.org/en/download
nvm: nvm install 22 && nvm use 22

Current: v${nodeVersion}
Required: >= 18.0.0
`;
fmt.error(msg.trim());
return;
}
fmt.success(`Node.js v${process.versions.node}`);
Expand Down