Skip to content

Remove obsolete Gemini and embedded showcase remnants#213

Merged
ProfRandom92 merged 1 commit into
mainfrom
cleanup/remove-gemini-and-embedded-showcase
May 24, 2026
Merged

Remove obsolete Gemini and embedded showcase remnants#213
ProfRandom92 merged 1 commit into
mainfrom
cleanup/remove-gemini-and-embedded-showcase

Conversation

@ProfRandom92
Copy link
Copy Markdown
Owner

Summary

  • Remove obsolete GEMINI.md
  • Remove the embedded showcase/ tree from the main repository
  • Update repository layout validation so showcase/app/package.json is no longer required
  • Update the layout test accordingly
  • Replace stale agent workflow wording around Gemini/showcase ownership
  • Remove stale showcase checks from docs/reports/check-report.md

Validation

  • npm run layout
  • pytest tests/test_check_repo_layout.py -q
  • pytest -q
  • npm run check

Result:

  • pytest -q: 384 passed
  • npm run check: passed

Scope

Maintenance-only cleanup.

Not changed:

  • dashboard UI wording
  • benchmark logic
  • contracts
  • fixtures
  • artifacts
  • README positioning

Next

README/industrial-positioning cleanup should be handled in a separate follow-up PR.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the showcase application and its associated source files, configurations, and assets from the repository, redirecting showcase development to a separate project. Updates were made to documentation, repository layout validation scripts, and tests to reflect this change. A review comment suggests further simplifying the repository layout tests by removing redundant file existence assertions that are already covered by the main validation function.

Comment on lines 5 to 7
assert (REPO_ROOT / "package.json").is_file()
assert (REPO_ROOT / "dashboard" / "app" / "package.json").is_file()
assert (REPO_ROOT / "showcase" / "app" / "package.json").is_file()
assert check_repo_layout() == []
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

These explicit file existence assertions are redundant because check_repo_layout() already validates these exact paths (and others) as part of its REQUIRED_FILES check. Removing them simplifies the test while maintaining the same level of validation.

Suggested change
assert (REPO_ROOT / "package.json").is_file()
assert (REPO_ROOT / "dashboard" / "app" / "package.json").is_file()
assert (REPO_ROOT / "showcase" / "app" / "package.json").is_file()
assert check_repo_layout() == []
assert check_repo_layout() == []

@ProfRandom92 ProfRandom92 merged commit f4c4ce6 into main May 24, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant