Skip to content

Rename stale industrial dashboard and workflow wording#217

Merged
ProfRandom92 merged 1 commit into
mainfrom
repo/rename-stale-industrial-actions-wording
May 24, 2026
Merged

Rename stale industrial dashboard and workflow wording#217
ProfRandom92 merged 1 commit into
mainfrom
repo/rename-stale-industrial-actions-wording

Conversation

@ProfRandom92
Copy link
Copy Markdown
Owner

Summary

  • Rename the stale GitHub Actions workflow display name from Industrial Validation to Replay Validation
  • Update dashboard-facing Industrial / Enterprise / Showcase copy to replay-validation and review wording
  • Rename dashboard package metadata only, without dependency or behavior changes

Validation

  • npm run layout
  • npm run typecheck
  • npm run validate
  • npm run build
  • pytest -q

Scope

Wording and metadata cleanup only. No validation logic, Python behavior, fixtures, artifacts, generated dist output, scripts, or dependencies changed.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request rebrands the 'Industrial Ops Console' to the 'Replay Validation Console' across the frontend and backend components, including updates to documentation, package metadata, and UI text. Feedback was provided regarding excessively long lines of JSX in 'OverviewPage.tsx' and 'ReplayPage.tsx', which hinder maintainability; the reviewer suggested refactoring these into a multi-line format for better readability.

<ReleaseHealthSummaryCard state={releaseHealth} />
<section className="grid cols-2">
<article className="card"><div className="card-header"><div><h3>Enterprise readiness boundaries</h3><p>Designed to make safe wording visible during review.</p></div><span className="badge warning">scoped</span></div><ul className="readiness-list"><li>Validated in repo/CI: deterministic prototype surfaces, schemas, reports, cloud workflows, and synthetic/static artifacts.</li><li>Planned next: governed pilot data, benchmark baselines, promotion evidence, and stakeholder-specific scripts.</li><li>Not claimed: production deployment, real-fleet correctness, certification, lossless reconstruction, or local showcase validation.</li></ul></article>
<article className="card"><div className="card-header"><div><h3>Validation scope boundaries</h3><p>Designed to make safe wording visible during review.</p></div><span className="badge warning">scoped</span></div><ul className="readiness-list"><li>Validated in repo/CI: deterministic prototype surfaces, schemas, reports, cloud workflows, and synthetic/static artifacts.</li><li>Planned next: governed pilot data, benchmark baselines, promotion evidence, and stakeholder-specific scripts.</li><li>Not claimed: production deployment, real-fleet correctness, certification, lossless reconstruction, or local demo validation.</li></ul></article>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This line is excessively long (over 600 characters), which makes it difficult to read and maintain. Breaking the JSX structure into multiple lines would significantly improve the readability of this component.

        <article className="card">
          <div className="card-header">
            <div>
              <h3>Validation scope boundaries</h3>
              <p>Designed to make safe wording visible during review.</p>
            </div>
            <span className="badge warning">scoped</span>
          </div>
          <ul className="readiness-list">
            <li>Validated in repo/CI: deterministic prototype surfaces, schemas, reports, cloud workflows, and synthetic/static artifacts.</li>
            <li>Planned next: governed pilot data, benchmark baselines, promotion evidence, and stakeholder-specific scripts.</li>
            <li>Not claimed: production deployment, real-fleet correctness, certification, lossless reconstruction, or local demo validation.</li>
          </ul>
        </article>


export function ReplayPage({ payload }: { payload: DashboardPayload }) {
return <div className="grid"><section className="grid cols-4"><article className="card"><h3>Determinism</h3><div className="metric">{payload.replay.stable ? 'Stable' : 'Drift'}</div><span className={`badge ${payload.replay.stable ? 'nominal' : 'critical'}`}>{payload.replay.mismatches} mismatches</span></article><article className="card"><h3>Replay passes</h3><div className="metric">{payload.replay.passes}</div><p>Last run {relativeTime(payload.replay.last_run_at)}</p></article><article className="card"><h3>Corpus size</h3><div className="metric">{payload.replay.corpus_size}</div><p>Golden industrial fixtures</p></article><article className="card"><h3>Tokenizer</h3><div className="metric">{payload.audit_summary.tokenizer_version}</div><p className="mono">{payload.audit_summary.tokenizer_drift_fingerprint.slice(0, 24)}</p></article></section><article className="card"><div className="card-header"><div><h3>Drift severity timeline</h3><p>Dataset-level findings from typed replay and forensic APIs.</p></div></div><BarChart data={payload.drift_severity_timeline.map((point) => ({ label: point.dataset, value: point.critical * 4 + point.high * 2 + point.medium, auxiliary: point.low }))} valueLabel={(value) => percent(value, 0)} /></article></div>;
return <div className="grid"><section className="grid cols-4"><article className="card"><h3>Determinism</h3><div className="metric">{payload.replay.stable ? 'Stable' : 'Drift'}</div><span className={`badge ${payload.replay.stable ? 'nominal' : 'critical'}`}>{payload.replay.mismatches} mismatches</span></article><article className="card"><h3>Replay passes</h3><div className="metric">{payload.replay.passes}</div><p>Last run {relativeTime(payload.replay.last_run_at)}</p></article><article className="card"><h3>Corpus size</h3><div className="metric">{payload.replay.corpus_size}</div><p>Golden replay fixtures</p></article><article className="card"><h3>Tokenizer</h3><div className="metric">{payload.audit_summary.tokenizer_version}</div><p className="mono">{payload.audit_summary.tokenizer_drift_fingerprint.slice(0, 24)}</p></article></section><article className="card"><div className="card-header"><div><h3>Drift severity timeline</h3><p>Dataset-level findings from typed replay and forensic APIs.</p></div></div><BarChart data={payload.drift_severity_timeline.map((point) => ({ label: point.dataset, value: point.critical * 4 + point.high * 2 + point.medium, auxiliary: point.low }))} valueLabel={(value) => percent(value, 0)} /></article></div>;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The line length here is extremely long (over 1000 characters), which is a significant maintainability issue. It is much better to format this JSX across multiple lines to make the structure clear and easier to modify in the future.

  return (
    <div className="grid">
      <section className="grid cols-4">
        <article className="card">
          <h3>Determinism</h3>
          <div className="metric">{payload.replay.stable ? 'Stable' : 'Drift'}</div>
          <span className={`badge ${payload.replay.stable ? 'nominal' : 'critical'}`}>
            {payload.replay.mismatches} mismatches
          </span>
        </article>
        <article className="card">
          <h3>Replay passes</h3>
          <div className="metric">{payload.replay.passes}</div>
          <p>Last run {relativeTime(payload.replay.last_run_at)}</p>
        </article>
        <article className="card">
          <h3>Corpus size</h3>
          <div className="metric">{payload.replay.corpus_size}</div>
          <p>Golden replay fixtures</p>
        </article>
        <article className="card">
          <h3>Tokenizer</h3>
          <div className="metric">{payload.audit_summary.tokenizer_version}</div>
          <p className="mono">{payload.audit_summary.tokenizer_drift_fingerprint.slice(0, 24)}</p>
        </article>
      </section>
      <article className="card">
        <div className="card-header">
          <div>
            <h3>Drift severity timeline</h3>
            <p>Dataset-level findings from typed replay and forensic APIs.</p>
          </div>
        </div>
        <BarChart
          data={payload.drift_severity_timeline.map((point) => ({
            label: point.dataset,
            value: point.critical * 4 + point.high * 2 + point.medium,
            auxiliary: point.low,
          }))}
          valueLabel={(value) => percent(value, 0)}
        />
      </article>
    </div>
  );
}

@ProfRandom92 ProfRandom92 merged commit 34005d1 into main May 24, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant