Revamp showcase to deterministic replay UI and static artifact validation#82
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for comptext-v7 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Code Review
This pull request refactors the showcase application into a static 'Replay validation console' that surfaces data from committed benchmark artifacts. The changes include a new validation script to ensure data consistency and a simplified React UI. Feedback highlights that the validation script's regex-based checks are brittle and lack benchmark-specific scoping, which could lead to false positives or runtime crashes. Additionally, it is recommended to replace the hardcoded personal repository URL with a configurable or relative path to better suit the project's industrial requirements.
Motivation
Description
showcase/app/src/data/benchmarkArtifacts.tscontaining committed benchmark card definitions, metric values, and artifact link lists that are intentionally copied from committed JSON artifacts.showcase/app/scripts/validate-static.mjsto read the new static data and repository artifacts, validate a new set of required phrases, and assert that derived artifact metrics are present in the static data, failing with clear errors if checks are missing.showcase/app/src/main.tsxwith a focused deterministic replay reviewer console that reads metrics from the staticbenchmarkArtifactsmodule, provides artifact links (repoHref), and simplifies the component tree to static metric cards, benchmark cards, pipeline, integrity badges, and artifact explorer.showcase/app/src/styles.csswith a redesigned, responsive dark theme, new layout rules, and styles for the new components.Testing
node showcase/app/scripts/validate-static.mjs, which executed the phrase and metric assertions and returned success (Deterministic replay showcase validation passed.).npm --prefix showcase/app run buildto verify the app compiles and the updated assets bundle successfully (build succeeded).Codex Task