Add tests and CI#4
Merged
JeroenDeDauw merged 14 commits intoProfessionalWiki:masterfrom Mar 10, 2025
gesinn-it-pub:master
Merged
Add tests and CI#4JeroenDeDauw merged 14 commits intoProfessionalWiki:masterfrom gesinn-it-pub:master
JeroenDeDauw merged 14 commits intoProfessionalWiki:masterfrom
gesinn-it-pub:master
Conversation
- enable phpcs and linting - add phpunit.xml.dist
- add test to display form for creating new page
- set coverage for MW 1.40
- add @group Database
- add more assertions - check all usage of #createpage parser function
Issue 1 - add GH actions and enable docker compose CI
Contributor
Author
|
@JeroenDeDauw : would be great if we could get some CI added. This PR is a bit older, but we can bring everything up to date after a merge in a sparate PR. CC @paladox @gesinn-it-ilm |
Contributor
|
I guess someone needs to approve a CI run for this repo? |
Contributor
Author
|
ping @kghbln |
|
Unfortunately there is no CI run to approve, since current master does not have GitHub CI. We'll either need to merge this and then follow-up on CI afterwards, or else merge a new stub CI PR so that GitHub can see there is a CI change in this PR. |
Contributor
Author
|
@paladox yupp, either @kghbln or @JeroenDeDauw needs to approve this PR first. Would be awesome to get some CI into this extension... |
Contributor
Author
|
@malberts if you can merge we can follow up. Not sure if Jeroen or Karsten needs to be involved |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added some tests (coverage ~89%) and CI. Configured to use Codecov (might require some token config on your side). Test based on SMW's JSONScript framework using docker-compose-ci.