Exception caught: Typed property MediaWiki\Parser\Parser::$ot must not be accessed before initialization

[bertrandgorge]

Setup

• Maps version: 13.0.0-alpha (setup with composer: 'mediawiki/maps "^12.0"')
• MW version: 1.43.5
• PHP version: 8.2.29
• SMW version (if applicable): 6.0.1

Issue

When editing a page using VisualEditor, if the page contains a Map, I have the following exception (when accessing $this->getParser()->recursiveTagParseFully at line 440 of src/SemanticMW/QueryHandler.php).

[85520170fdea84c79286bab5] Exception caught: Typed property MediaWiki\Parser\Parser::$ot must not be accessed before initialization

According to CoPilot, the issue is that with MW 1.43 there's a need to call startExternalParse when getting the Parser, so that $ot can be properly typed before use.

Patch follows.

[bertrandgorge]

Actually, I'm starting to think that this change will also solve that issue : Open-CSP/WikiSearch#68

When using $parser = MediaWikiServices::getInstance()->getParser(); in QueryHandler.php, in particular to build tooltips out of templates, the parser instance is the singleton for the current page, and not a new one dedicated to building those tooltips. I'm wondering if it could be the cause of the race condition that I suspect in the issue above:

1. WikiSearch prepares the WikiSearch config out of the page (uses the parser)
2. Maps resets the parser and wipes the config
3. WikiSearch returns an empty config

In the change I propose (actually a suggestion from copilot), the parser is created specifically for the tooltips job:

$this->parser = MediaWikiServices::getInstance()->getParserFactory()->create();

I'm still checking up on my wiki to see if it fixes the problem definitely but I'm quite confident!