Skip to content

Incompatible with latest SMW master #895

@SomeMWDev

Description

@SomeMWDev

SemanticMediaWiki/SemanticMediaWiki@bb4680d added a return type declaration to FileExportPrinter::getFileName(), but the method in Maps doesn't have a return type declaration:

public function getFileName( QueryResult $queryResult ) {

This causes an error when e.g. visiting Special:Ask:

[a5e8b20eee8ad94e0e4901b7] /wiki/Special:Ask   PHP Fatal Error from line 137 of /srv/mediawiki/1.45/extensions/Maps/src/SemanticMW/KmlPrinter.php: Declaration of Maps\SemanticMW\KmlPrinter::getFileName(SMW\Query\QueryResult $queryResult) must be compatible with SMW\Query\ResultPrinters\FileExportPrinter::getFileName(SMW\Query\QueryResult $queryResult): string|false

from /srv/mediawiki/1.45/extensions/Maps/src/SemanticMW/KmlPrinter.php(137)
#0 [internal function]: MediaWiki\Exception\MWExceptionHandler::handleFatalError()
#1 {main}

SMW: 7.0.0-alpha
Maps: 12.1.1

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions