Split Property Definition attributes into constraints/displayAttributes#628
Closed
JeroenDeDauw wants to merge 1 commit into
Closed
Split Property Definition attributes into constraints/displayAttributes#628JeroenDeDauw wants to merge 1 commit into
JeroenDeDauw wants to merge 1 commit into
Conversation
The JSON serialization format for Property Definitions now nests type-specific attributes into `constraints` and `displayAttributes` objects, preparing for the Views feature where display attributes can be overridden per-View while constraints cannot. Domain objects (PHP classes and TS interfaces) remain flat — the nesting is only at the serialization boundary. This avoids breaking internal consumers like renderers, validators, and editors. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
JeroenDeDauw
force-pushed
the
split-property-definition-attributes
branch
2 times, most recently
from
e12dc0b to
7388a20
Compare
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I now think this is the wrong approach
First implementation step towards the proposed Views approach. Pending ADR acceptance.
Follows
Summary
constraintsanddisplayAttributesobjects, preparing for the Views feature where displayattributes can be overridden per-View while constraints cannot.
serialization boundary, avoiding changes to internal consumers like renderers, validators,
and editors.
precision). Other types have onlyconstraints.
Test plan
🤖 Generated with Claude Code