Provide revision content to PagePropertyProviderContext#982
Open
JeroenDeDauw wants to merge 2 commits into
Open
Provide revision content to PagePropertyProviderContext#982JeroenDeDauw wants to merge 2 commits into
JeroenDeDauw wants to merge 2 commits into
Conversation
Fixes #979 PagePropertiesBuilder already loaded the revision's main slot content and parsed it to extract categories, but threw everything else away. Providers wanting to derive Page Properties from the content had to re-fetch and re-parse it themselves - and since the context carries no revision ID, they could only look up the latest revision of the page, which is redundant work and subtly racy. The context now additionally exposes: * `content` - the serialized main slot content, e.g. the wikitext * `contentModel` - e.g. "wikitext" * `parserProperties` - the MediaWiki page properties recorded while parsing the content (e.g. "defaultsort", or values set by parser hooks via ParserOutput::setPageProperty) Design notes: * The context is a Domain value object holding only scalars and arrays. Exposing RevisionRecord, Content, or ParserOutput directly would put MediaWiki core classes into the Domain layer and make provider tests heavyweight. The relevant data is flattened instead, following the approach already used for `categories`. * `parserProperties` covers the template-expansion-safe path: extensions whose parser hooks already record values during the parse can read them back in their provider instead of re-analyzing raw markup. The parse NeoWiki already performs for categories is reused, so no additional parse happens. * When the content is unavailable (e.g. suppressed), `content` and `contentModel` are empty strings and `parserProperties` is empty, matching the existing behavior of `categories`. Note: content-derived properties refresh only when a new revision is stored, so values coming from transcluded templates can go stale - the same existing limitation as categories. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Follow-up polish on the extending.md guidance for the new context fields: recommend deriving Page Properties from the robust parse products (categories, parserProperties) and frame raw content/contentModel as the escape hatch for custom, non-wikitext content models rather than the default. Also carries the "parserProperties is a parse input, not the NeoWiki Page Properties you return" disambiguation into the docs, where provider authors actually read it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
JeroenDeDauw
commented
Jul 3, 2026
| public string $lastEditor, | ||
| public string $content, | ||
| public string $contentModel, | ||
| public array $parserProperties, |
Member
Author
There was a problem hiding this comment.
@osnard unsure if this is sufficient for your use cases and which of those you actually need? Perhaps just parserProperties?
JeroenDeDauw
added
the
BlueSpice
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #979
PagePropertiesBuilderalready loaded the revision's main slot content and parsed it to extract categories, but threw everything else away. Providers wanting to derive Page Properties from the content had to re-fetch and re-parse it themselves - and since the context carries no revision ID, they could only look up the latest revision of the page, which is redundant work and subtly racy.The context now additionally exposes:
content- the serialized main slot content, e.g. the wikitextcontentModel- e.g. "wikitext"parserProperties- the MediaWiki page properties recorded while parsing the content (e.g. "defaultsort", or values set by parser hooks viaParserOutput::setPageProperty)Design notes:
RevisionRecord,Content, orParserOutputdirectly would put MediaWiki core classes into the Domain layer and make provider tests heavyweight. The relevant data is flattened instead, following the approach already used forcategories.parserPropertiescovers the template-expansion-safe path: extensions whose parser hooks already record values during the parse can read them back in their provider instead of re-analyzing raw markup. The parse NeoWiki already performs for categories is reused, so no additional parse happens.contentandcontentModelare empty strings andparserPropertiesis empty, matching the existing behavior ofcategories.Note: content-derived properties refresh only when a new revision is stored, so values coming from transcluded templates can go stale - the same existing limitation as categories.