Skip to content

Conversation

@NsdHSO
Copy link
Contributor

@NsdHSO NsdHSO commented Dec 4, 2023

πŸ› οΈ Changes Made:

  • Introduced dynamic styling using CSS variables, implementing a height animation effect for visual appeal.

πŸŽ‰ Benefits:

  • Enhances user engagement through playful and diverse content.

  • Improves the visual experience with a smooth height animation effect

@agjs agjs self-requested a review December 5, 2023 09:21
Copy link
Collaborator

@agjs agjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NsdHSO The PR looks great. I have only one comment, and that is, let's keep the new class name that you introduced follow the general class names principles. Or in simple words, classes in CSS are always lowercased. Apart from that, it would also align with Tailwind utility classes.

So let's rename this heightAnimation to height-animation.

E.g.

animate-height-animation

Also, as you can see, I had to update the jest snapshot in the tests, so once you make this change, make sure to re-generate the snapshot, once you change the class name, otherwise, tests will fail.

Thanks a lot for putting in the time to do the PR. Hopefully, more will come πŸ‘πŸ».

@agjs agjs self-requested a review December 5, 2023 10:01
@agjs agjs merged commit b7f01ab into Programmer-Network:master Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants