Util Classes (PzAnalysis) : pz_analysis_hpp created, pz_error updated#7
Merged
tushar3q34 merged 6 commits intoProgramming-Club-Org:devfrom Aug 13, 2025
Merged
Conversation
tushar3q34
requested changes
Aug 11, 2025
Member
tushar3q34
left a comment
tushar3q34
left a comment
There was a problem hiding this comment.
Please resolve the comments and do the needful changes.
I'll review again for the logic part after these changes.
tushar3q34
changed the title
PzAnalysis) : pz_analysis_hpp created, pz_error updated
Ovetsarilish
requested changes
Aug 12, 2025
tushar3q34
requested changes
Aug 12, 2025
Member
tushar3q34
left a comment
tushar3q34
left a comment
There was a problem hiding this comment.
Please do the following changes.
tushar3q34
reviewed
Aug 12, 2025
…ate, moved .cpp file
tushar3q34
approved these changes
Aug 12, 2025
Member
tushar3q34
left a comment
tushar3q34
left a comment
There was a problem hiding this comment.
Do these minor changes. Except that, LGTM.
Member
|
@architabanka Can you include issue hash in PR description. |
tushar3q34
approved these changes
Aug 13, 2025
This was referenced Sep 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PzAnalysisType : An enum class specifying the analysis type, either exact string matching (EXACT) or regular expression matching (REGEX) for now.
PzAnalysisImpl : Defines the interface for analysis implementations that operate on PzBuffer. It requires derived classes to implement the analyze method.
PzAnalysisExact and PzAnalysisRegex: Skeleton of implementations of PzAnalysisImpl for exact string search and regex-based search respectively. Will handle validation, error reporting and analysis logic.
PzAnalysis: The main class that manages analysis operations. It holds a shared pointer to PzCore which provides access to PzBuffer. Based on the requested analysis type, it delegates to the appropriate implementation. Supports move semantics and disallows copying to reduce overhead.
Error handling by reporting issues through PzError.
Fixes #3