LEDs #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

Nummun14 merged 32 commits into main from leds

Nov 28, 2024

Member

Nummun14 commented Nov 11, 2024

No description provided.

Nummun14 added 6 commits

November 8, 2024 11:33


          implemented AddressableLed and most of CANdleLed

8962ede


          finished CANdleLEDStrip and added LEDCommands

f248c81


          added colorFLowCommand

92d91dc


          made code more efficient

eb22052


          cleaned

46bb512


          added jDocs for the patterns, and fixed colorFlow inverted

8b00706

Nummun14 requested review from Strflightmight09 and levyishai

November 11, 2024 09:20


          added requirements

61cac26

Strflightmight09 reviewed

View reviewed changes

Member

Strflightmight09 left a comment

I'm pretty sure you're supposed to make something like an IO layer. If you're not sure what I mean, check the old vision code

Member Author

Nummun14 commented Nov 11, 2024 •

edited

Loading

I'm pretty sure you're supposed to make something like an IO layer. If you're not sure what I mean, check the old vision code

Why would the LEDs need an IO layer?


          made CANdleLEDStrip use AddressableLEDStrip in sim

6abcf66

Nummun14 requested a review from Strflightmight09

November 11, 2024 16:12

Strflightmight09 requested changes

View reviewed changes

src/main/java/org/trigon/hardware/misc/leds/LEDStrip.java Outdated Show resolved Hide resolved

src/main/java/org/trigon/hardware/misc/leds/LEDStrip.java Outdated Show resolved Hide resolved

src/main/java/org/trigon/hardware/misc/leds/AddressableLEDStrip.java Outdated Show resolved Hide resolved

src/main/java/org/trigon/hardware/misc/leds/AddressableLEDStrip.java Outdated Show resolved Hide resolved

src/main/java/org/trigon/hardware/misc/leds/AddressableLEDStrip.java Outdated Show resolved Hide resolved

src/main/java/org/trigon/hardware/misc/leds/CANdleLEDStrip.java Outdated Show resolved Hide resolved

src/main/java/org/trigon/hardware/misc/leds/CANdleLEDStrip.java Outdated Show resolved Hide resolved

src/main/java/org/trigon/hardware/misc/leds/CANdleLEDStrip.java Outdated Show resolved Hide resolved

src/main/java/org/trigon/hardware/misc/leds/CANdleLEDStrip.java Outdated Show resolved Hide resolved

src/main/java/org/trigon/hardware/misc/leds/CANdleLEDStrip.java Outdated Show resolved Hide resolved

Strflightmight09 reviewed

View reviewed changes

src/main/java/org/trigon/hardware/misc/leds/LEDStrip.java Outdated Show resolved Hide resolved


          cleaned a bunch

b97318a

Nummun14 requested a review from Strflightmight09

November 12, 2024 10:56

Nummun14 added 8 commits

November 12, 2024 15:59


          cleaned stuff


          added jDocs and improved simulation

ac14f6e


          improved setLED method

9586d5c


          cleaned up colorFlow

40ba58d


          implementing this was soooooooooooooooooo annoying

f10e39c


          made rainbow command work with params, and fixed var name

f6964e9


          removed extra new line

f5955aa


          fixed commands, and removed shouldLoop (We don't need it Ezra)

087e07f

Strflightmight09 requested changes

View reviewed changes

src/main/java/org/trigon/hardware/misc/leds/LEDStrip.java Outdated Show resolved Hide resolved

src/main/java/org/trigon/hardware/misc/leds/LEDStrip.java Outdated Show resolved Hide resolved

src/main/java/org/trigon/hardware/misc/leds/LEDStrip.java Outdated Show resolved Hide resolved

src/main/java/org/trigon/hardware/misc/leds/LEDStrip.java Outdated Show resolved Hide resolved

src/main/java/org/trigon/hardware/misc/leds/LEDStrip.java Outdated Show resolved Hide resolved

src/main/java/org/trigon/hardware/misc/leds/LEDCommands.java Outdated Show resolved Hide resolved

src/main/java/org/trigon/hardware/misc/leds/LEDCommands.java Outdated Show resolved Hide resolved

src/main/java/org/trigon/hardware/misc/leds/LEDCommands.java Show resolved Hide resolved

src/main/java/org/trigon/hardware/misc/leds/LEDCommands.java Outdated Show resolved Hide resolved

src/main/java/org/trigon/hardware/misc/leds/CANdleLEDStrip.java Outdated Show resolved Hide resolved

Nummun14 added 3 commits

November 13, 2024 21:32


          cleaned code and jDocs

30ec6a6


          reverted Command stuff, will figure out a solution tommorow

ac7ac55


          finally fixed critical error!!!!!!!!!!!!!!!!!!!!!!!! 🎱

77f1f14

Nummun14 requested a review from Strflightmight09

November 13, 2024 20:56


          Forgot to do this earlier

ae3d972

Nummun14 requested a review from Strflightmight09

November 15, 2024 10:20

Strflightmight09 approved these changes

View reviewed changes


          Merge branch 'main' into leds

fa2272b

Strflightmight09 requested changes

View reviewed changes

src/main/java/org/trigon/hardware/misc/leds/AddressableLEDStrip.java Outdated Show resolved Hide resolved

levyishai requested changes

View reviewed changes

src/main/java/org/trigon/hardware/misc/leds/AddressableLEDStrip.java Outdated Show resolved Hide resolved

src/main/java/org/trigon/hardware/misc/leds/AddressableLEDStrip.java Show resolved Hide resolved

src/main/java/org/trigon/hardware/misc/leds/CANdleLEDStrip.java Outdated Show resolved Hide resolved

src/main/java/org/trigon/hardware/misc/leds/CANdleLEDStrip.java Outdated Show resolved Hide resolved

src/main/java/org/trigon/hardware/misc/leds/LEDCommands.java Outdated Show resolved Hide resolved

src/main/java/org/trigon/hardware/misc/leds/CANdleLEDStrip.java Outdated Show resolved Hide resolved

src/main/java/org/trigon/hardware/misc/leds/CANdleLEDStrip.java Outdated Show resolved Hide resolved

src/main/java/org/trigon/hardware/misc/leds/CANdleLEDStrip.java Outdated Show resolved Hide resolved

src/main/java/org/trigon/hardware/misc/leds/CANdleLEDStrip.java Outdated Show resolved Hide resolved

src/main/java/org/trigon/hardware/misc/leds/CANdleLEDStrip.java Show resolved Hide resolved


          cleaned a bit, optimized, and stuff

b2dce8e

Nummun14 requested review from Strflightmight09 and levyishai

November 18, 2024 08:23

Strflightmight09 requested changes

View reviewed changes

src/main/java/org/trigon/hardware/misc/leds/AddressableLEDStrip.java Show resolved Hide resolved

src/main/java/org/trigon/hardware/misc/leds/CANdleLEDStrip.java Outdated Show resolved Hide resolved


          fixed method name and cleaned a bit

e29f91f

Nummun14 requested a review from Strflightmight09

November 19, 2024 10:28

Strflightmight09 requested changes

View reviewed changes

src/main/java/org/trigon/hardware/misc/leds/CANdleLEDStrip.java Outdated Show resolved Hide resolved

Nummun14 requested a review from Strflightmight09

November 20, 2024 13:36

Nummun14 added 2 commits

November 24, 2024 15:07


          simple is good

82a022b


          minor optimization thing

4ee8a80

Strflightmight09 approved these changes

View reviewed changes

levyishai requested changes

View reviewed changes

src/main/java/org/trigon/hardware/misc/leds/AddressableLEDStrip.java Outdated Show resolved Hide resolved

src/main/java/org/trigon/hardware/misc/leds/AddressableLEDStrip.java Outdated Show resolved Hide resolved

src/main/java/org/trigon/hardware/misc/leds/CANdleLEDStrip.java Outdated Show resolved Hide resolved

src/main/java/org/trigon/hardware/misc/leds/CANdleLEDStrip.java Show resolved Hide resolved

src/main/java/org/trigon/hardware/misc/leds/LEDCommands.java Show resolved Hide resolved

src/main/java/org/trigon/hardware/misc/leds/LEDCommands.java Show resolved Hide resolved


          cleaning. jdocs and rainbow inverted

e3c9f6d

levyishai requested changes

View reviewed changes

Member

levyishai left a comment •

edited

Loading

I would create two factory functions in LEDStrip similar to how you create a SimpleSensor (just without IO layers). This will make the whole sim logic easier, and make everything more abstract.

levyishai requested a review from Strflightmight09

November 26, 2024 15:44

Nummun14 added 2 commits

November 26, 2024 22:39


          sim cleaning thing. Still working on annoying LED_STRIPS array bug

3903b82


          cleaned a bit, finished sim logic and added initiateAddressableLED

7b34c7c

Nummun14 commented

View reviewed changes

src/main/java/org/trigon/hardware/misc/leds/LEDStrip.java Show resolved Hide resolved

levyishai requested changes

View reviewed changes

src/main/java/org/trigon/hardware/misc/leds/LEDStrip.java Show resolved Hide resolved

src/main/java/org/trigon/hardware/misc/leds/LEDStrip.java Outdated Show resolved Hide resolved

src/main/java/org/trigon/hardware/misc/leds/LEDStrip.java Show resolved Hide resolved

src/main/java/org/trigon/hardware/misc/leds/LEDCommands.java Outdated Show resolved Hide resolved

src/main/java/org/trigon/hardware/misc/leds/LEDStrip.java Outdated Show resolved Hide resolved

src/main/java/org/trigon/hardware/misc/leds/AddressableLEDStrip.java Show resolved Hide resolved

src/main/java/org/trigon/hardware/misc/leds/AddressableLEDStrip.java Show resolved Hide resolved

src/main/java/org/trigon/hardware/misc/leds/AddressableLEDStrip.java Show resolved Hide resolved

src/main/java/org/trigon/hardware/misc/leds/AddressableLEDStrip.java Show resolved Hide resolved

src/main/java/org/trigon/hardware/misc/leds/AddressableLEDStrip.java Show resolved Hide resolved


          cleaning

927817b

Nummun14 requested a review from levyishai

November 28, 2024 17:17

levyishai approved these changes

View reviewed changes

Member

levyishai left a comment

Looks great

Nummun14 merged commit 56be586 into main

3 checks passed

Nummun14 deleted the leds branch

November 28, 2024 21:56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet