General Update #19

Nummun14 · 2024-11-19T12:57:50Z

No description provided.

was in the middle of TalonFX

just finished MirrorablePose2d

src/main/java/org/trigon/hardware/rev/spark/SparkMotor.java

src/main/java/org/trigon/hardware/RobotHardwareStats.java

src/main/java/org/trigon/utilities/mirrorable/MirrorablePose2d.java

src/main/java/org/trigon/utilities/mirrorable/MirrorableRotation2d.java

src/main/java/org/trigon/utilities/mirrorable/MirrorableTranslation3d.java

src/main/java/org/trigon/hardware/misc/KeyboardController.java

src/main/java/org/trigon/hardware/phoenix6/talonfx/TalonFXMotor.java

src/main/java/org/trigon/hardware/rev/spark/SparkMotor.java

src/main/java/org/trigon/hardware/simulation/ElevatorSimulation.java

src/main/java/org/trigon/utilities/mirrorable/MirrorablePose2d.java

src/main/java/org/trigon/utilities/mirrorable/MirrorableTranslation3d.java

src/main/java/org/trigon/utilities/mirrorable/MirrorableRotation2d.java

Strflightmight09

As a general rule: "Whether" indicates a choice between two options. You cannot say "Whether" and then only present one option

src/main/java/org/trigon/hardware/RobotHardwareStats.java

src/main/java/org/trigon/hardware/simulation/ElevatorSimulation.java

src/main/java/org/trigon/hardware/simulation/FlywheelSimulation.java

src/main/java/org/trigon/hardware/simulation/SimpleMotorSimulation.java

src/main/java/org/trigon/hardware/simulation/SingleJointedArmSimulation.java

src/main/java/org/trigon/utilities/mirrorable/MirrorableRotation2d.java

src/main/java/org/trigon/utilities/mirrorable/MirrorableTranslation3d.java

levyishai

Try to be more informative in your javadocs. Think about the person that reads them.

src/main/java/org/trigon/hardware/RobotHardwareStats.java

src/main/java/org/trigon/hardware/SignalThreadBase.java

src/main/java/org/trigon/hardware/SignalUtilities.java

src/main/java/org/trigon/hardware/misc/XboxController.java

levyishai

no need for general explanation in functions where you only return, and the general explanation has no additional value. For example:

     * Gets the ID of the motor.
     *
     * @return the ID of the motor
     */```
     should be 
     ```/**
     * @return the ID of the motor
     */```

src/main/java/org/trigon/hardware/misc/simplesensor/SimpleSensor.java

src/main/java/org/trigon/hardware/phoenix6/talonfx/TalonFXMotor.java

src/main/java/org/trigon/utilities/mirrorable/Mirrorable.java

src/main/java/org/trigon/hardware/SignalThreadBase.java

…!!!!!!!!

src/main/java/org/trigon/hardware/rev/spark/io/RealSparkIO.java

src/main/java/org/trigon/hardware/rev/spark/io/SimulationSparkIO.java

src/main/java/org/trigon/utilities/Conversions.java

…oder

src/main/java/org/trigon/hardware/rev/spark/io/SimulationSparkIO.java

levyishai

@Strflightmight09 please review

src/main/java/org/trigon/hardware/phoenix6/Phoenix6SignalThread.java

src/main/java/org/trigon/hardware/phoenix6/cancoder/CANcoderEncoder.java

src/main/java/org/trigon/hardware/rev/spark/io/SimulationSparkIO.java

src/main/java/org/trigon/hardware/rev/sparkecnoder/AbsoluteSparkEncoder.java

src/main/java/org/trigon/hardware/rev/sparkecnoder/RelativeSparkEncoder.java

src/main/java/org/trigon/hardware/simulation/ElevatorSimulation.java

src/main/java/org/trigon/hardware/simulation/SimpleMotorSimulation.java

src/main/java/org/trigon/utilities/mirrorable/Mirrorable.java

src/main/java/org/trigon/hardware/rev/sparkecnoder/RelativeSparkEncoder.java

src/main/java/org/trigon/hardware/rev/sparkecnoder/SparkEncoder.java

src/main/java/org/trigon/hardware/rev/sparkecnoder/AbsoluteSparkEncoder.java

src/main/java/org/trigon/utilities/mirrorable/Mirrorable.java

Strflightmight09 · 2024-12-03T09:59:43Z

'rev/sparkecnoder`

src/main/java/org/trigon/hardware/phoenix6/Phoenix6SignalThread.java

src/main/java/org/trigon/utilities/mirrorable/Mirrorable.java

Nummun14 · 2024-12-03T10:25:39Z

@levyishai plz review

src/main/java/org/trigon/hardware/rev/sparkencoder/SparkEncoder.java

levyishai

Create a release and update the template

Nummun14 added 3 commits November 18, 2024 19:01

started cleaning

73c962e

was in the middle of TalonFX

added a BUNCH more jDocs. (I'm litterally falling asleep rn)

48b1fef

just finished MirrorablePose2d

finished adding jDocs

772ff20

Nummun14 requested a review from Strflightmight09 November 19, 2024 12:58

Nummun14 commented Nov 19, 2024

View reviewed changes

src/main/java/org/trigon/hardware/rev/spark/SparkMotor.java Outdated Show resolved Hide resolved

Nummun14 requested a review from levyishai November 19, 2024 12:59

Strflightmight09 requested changes Nov 20, 2024

View reviewed changes

grammer sucks

8590e74

Nummun14 requested a review from Strflightmight09 November 20, 2024 19:12

updated libraries and adapted code to it

8fd094b

Nummun14 changed the title ~~General Cleanup~~ General Update Nov 21, 2024

Strflightmight09 requested changes Nov 22, 2024

View reviewed changes

javadocs are annoying. So is REV. So am I.

9641ef3

Nummun14 requested a review from Strflightmight09 November 22, 2024 12:35

Strflightmight09 reviewed Nov 24, 2024

View reviewed changes

Programming-TRIGON deleted a comment from Nummun14 Nov 24, 2024

"Javadocs are actually quite fun" - Ezra Gryn 2024

3bc9934

Nummun14 requested a review from Strflightmight09 November 24, 2024 12:36

Strflightmight09 requested changes Nov 25, 2024

View reviewed changes

erm actually🤓

f4b54ed

Nummun14 requested a review from Strflightmight09 November 25, 2024 11:10

Strflightmight09 approved these changes Nov 25, 2024

View reviewed changes

levyishai reviewed Nov 25, 2024

View reviewed changes

levyishai requested changes Nov 25, 2024

View reviewed changes

JAVADOCS!!! and mirroable fix

d659a54

Nummun14 requested a review from levyishai November 26, 2024 11:03

levyishai requested a review from Strflightmight09 November 26, 2024 15:17

Nummun14 added 2 commits December 2, 2024 20:45

camel case, and removed testing

9b34333

cleaned up solution. SIM WORKS!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!…

4da3434

…!!!!!!!!