Flippable

[levyishai]

No description provided.

[Copilot]

Copilot reviewed 5 out of 8 changed files in this pull request and generated no comments.

Files not reviewed (3)

• src/main/java/org/trigon/utilities/mirrorable/MirrorablePose2d.java: Evaluated as low risk
• src/main/java/org/trigon/utilities/mirrorable/MirrorableRotation2d.java: Evaluated as low risk
• src/main/java/org/trigon/utilities/mirrorable/MirrorableTranslation3d.java: Evaluated as low risk

Comments suppressed due to low confidence (8)

src/main/java/org/trigon/utilities/flippable/FlippableTranslation3d.java:8

• The class documentation mentions 'FlippableTranslation3d' instead of 'FlippableTranslation2d'.

* A class that represents a {@link Translation3d} that can be flipped when the robot is on the red alliance.

src/main/java/org/trigon/utilities/flippable/FlippableTranslation3d.java:35

• The method documentation should explicitly state that the Z value will have no change.

protected Translation3d flip(Translation3d translation) {

src/main/java/org/trigon/utilities/flippable/FlippableTranslation3d.java:15

• The constructor documentation has a minor inconsistency in the parameter description.

@param nonFlippedTranslation     the translation to flip

src/main/java/org/trigon/utilities/flippable/FlippableTranslation2d.java:11

• The Javadoc comment incorrectly refers to FlippableTranslation3d instead of FlippableTranslation2d.

* Creates a new FlippableTranslation3d with the given translation.

src/main/java/org/trigon/utilities/flippable/FlippableTranslation2d.java:22

• The Javadoc comment incorrectly refers to FlippableTranslation3d instead of FlippableTranslation2d.

* Creates a new FlippableTranslation3d with the given x and y values.

src/main/java/org/trigon/utilities/flippable/FlippablePose2d.java:43

• [nitpick] The parameter name 'rotation' is ambiguous. It should be renamed to 'rotationRadians' to clearly indicate that it represents radians.

public FlippablePose2d(Translation2d translation2d, double rotation, boolean shouldFlipWhenRedAlliance) {

src/main/java/org/trigon/utilities/flippable/FlippableRotation2d.java:13

• The term 'non flipped rotation' should be hyphenated as 'non-flipped rotation' for consistency.

@param nonFlippedRotation        the non flipped rotation when the robot is on the blue alliance

src/main/java/org/trigon/utilities/flippable/FlippableRotation2d.java:55

• The comment for 'fromRotations' should be updated to match the format of 'fromDegrees' and 'fromRadians'.

@param rotations                 the value of the angle in rotations