Feat/annotation arrows #282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Example: |
Member
|
Please rebase on |
Member
|
While rebasing, also edit the arrow commit's message to include the information from the PR (what it fixes, small description) |
|
|
||
| private static final double MINIMUM_LABEL_WIDTH = 10.0; | ||
| private static final double MINIMUM_LABEL_HEIGHT = 12.0; | ||
| private static final double MINIMUM_ARROW_WIDTH = 25.0; |
Member
There was a problem hiding this comment.
Minimum arrow with is alrgeer than minimum label width? Sure this is desired? (weird overlapping with many small nodes)
Collaborator
Author
There was a problem hiding this comment.
If the annotation is smaller than MINIMUM_LABEL_WIDTH the label (text) isn't drawn. If the annotation is smaller than MINIMUM_ARROW_WIDTH the arrow won't be drawn.
FarisElghlan
force-pushed
the
feat/annotation-arrows
branch
from
75a1a99 to
244e58d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added arrows to the annotations to indicate their direction.
Fixes #257