Tweaks for the "Improve Plugin" PR#4
Merged
jdevalk merged 2 commits intojdv/improve-pluginfrom Oct 10, 2025
Merged
Conversation
Contributor
|
Test on Playground |
jdevalk
approved these changes
Oct 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements following changes:
my-plugin/brand-asset, so that is changed. It will be a "breaking" change since old block will no longer be recognized by Gutenberg, but that was already the case when the block was renamed frommy-plugin/color-schemetomy-plugin/brand-assetsinit_hooksmethod was called in the constructor of the Settings and Front End classes, but that makes hooks being added multiple times if class is instantiated more than once - which was done here (so hooks were added twice on front end). I changedinit_hooksmethods to be public, so they can be called explicitly (or we can convert classes to singleton pattern).