Add a settings popover to exclude post-types from tracking#51
Merged
Add a settings popover to exclude post-types from tracking#51
Conversation
Contributor
|
Test on Playground |
Member
|
I've been discussing this with Marieke. We'd like to change it; instead of making it "Exclude", I think we should make it "Include" and we should default to Posts and Pages "on" and the rest "off". |
jdevalk
requested changes
Jul 8, 2024
Member
|
Also; hitting "Save" should trigger a page refresh, as it changes the data that should be displayed. |
jdevalk
approved these changes
Jul 8, 2024
ilicfilip
added a commit
that referenced
this pull request
Feb 6, 2026
Use get_admin_menu_icon() from the branding system instead of hardcoded icon_progress_planner.svg references, so hosts with custom branding automatically get their own icon everywhere. Closes #51 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This PR adds a popover for settings, to allow excluding post-types from tracking.
The settings popover was added to the header, right next to the months selector:
Initially, I wanted to add a setting to select which post-types will be included, however that would lead to lots of complications if post-types get added later. With that in mind, it seemed a better option to add a setting to exclude post-types.
To avoid designing a new page etc, it seemed better to reuse the popover API we already implement - especially since we only have 1 option. If in the future we add more options, we may want to rethink that approach
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
UI changes
Documentation
Quality assurance