Feature adjustment request: have DISCARD JOB feature always cancel job completely

[ErikKirkstein]

Currently in MoveOn's Spoke, there is a feature that allows you to cancel a job while either loading texters or loading contacts.

Currently, if you click DISCARD JOB on a contact upload which appears to be stuck, the feature just stops the loading process at whichever % of loading it was at when the DISCARD JOB button was clicked.

Example:

Loading 20,000 contacts and you click DISCARD JOB at 50%, it loads 10,000 contacts and allows you to start the campaign.

The issue here is that the admin does not know what 10k contacts Spoke actually loaded (especially since Spoke scrubs for duplicates etc) so it is effectively an unusable Spoke campaign.

To make this feature more effective, it would be helpful to have it instead end the loading completely, effectively allowing you to start over from the beginning with 0% of contacts loaded into the Spoke campaign.

[schuyler1d]

@ErikKirkstein See below for why that's maybe not the best idea. I think if you click 'discard job' and you want to start over, you can -- just enter the SQL again and start the run -- it will delete the previously uploaded contacts and start from the beginning (or should! if it doesn't, then THAT's the bug).

I'm not sure that's very easy --the problem is basically why I called it 'discard job' rather than 'cancel job' -- if lambda is running something we don't know where it's running or how to stop it.
For uploadContacts -- specifically -- we already check to see if the job was completed, and so drop it: https://github.com/MoveOnOrg/Spoke/blob/main/src/workers/jobs.js#L183
If you are asking that if we call Discard Job then we should delete all the contacts? I think that could be a little risky, too -- if a job 'gets stuck' at the end -- i.e. it got all the contacts and then it's just hanging on, then we don't necessarily want to delete all that work, just to clean up the hung job.

[ErikKirkstein]

Thanks, Sky. Very helpful. *I think if you click 'discard job' and you want to start over, you can -- just enter the SQL again and start the run -- it will delete the previously uploaded contacts <https://github.com/MoveOnOrg/Spoke/blob/main/src/workers/jobs.js#L346-L348> and start from the beginning (or should! if it doesn't, then THAT's the bug).* Regarding this "start over" process of just entering the query again to load the contacts, will and/or /can that also work with a csv file?

…

On Wed, Sep 12, 2018 at 12:06 PM, Schuyler Duveen ***@***.***> wrote: @ErikKirkstein <https://github.com/ErikKirkstein> See below for why that's maybe not the best idea. I think if you click 'discard job' and you want to start over, you can -- just enter the SQL again and start the run -- it will delete the previously uploaded contacts <https://github.com/MoveOnOrg/Spoke/blob/main/src/workers/jobs.js#L346-L348> and start from the beginning (or should! if it doesn't, then THAT's the bug). I'm not sure that's very easy -- I can comment on the issue, but the problem is basically why I called it 'discard job' rather than 'cancel job' -- if lambda is running something we don't know where it's running or how to stop it. For uploadContacts -- specifically -- we already check to see if the job was completed, and so drop it: https://github.com/MoveOnOrg/ Spoke/blob/main/src/workers/jobs.js#L183 Is he asking that if we call discard Job then we should delete all the contacts? I think that could be a little risky, too -- if a job 'gets stuck' at the end -- i.e. it got all the contacts and then it's just hanging on, then we don't necessarily want to delete all that work, just to clean up the hung job. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <https://github.com/MoveOnOrg/Spoke/issues/899#issuecomment-420704943>, or mute the thread <https://github.com/notifications/unsubscribe-auth/Aep1fS2zxiHpk-CZMGTNSqz1wdxGXE6Nks5uaTDsgaJpZM4WlruQ> .

-- Erik Kirkstein *he/him/his* Text Team Campaigns Director, MoveOn <http://MoveOn.Org> erik.kirkstein@moveon.org

[schuyler1d]

Yes, same thing. You can always restart an action. We do not discard the results of an incomplete job because sometimes those results are done/mostly done