tags in message review MVP (and conversation permalink)#1590
Merged
lperson merged 19 commits intoProgressiveCoders:stage-main-62-wfpfrom Jun 9, 2020
Merged
tags in message review MVP (and conversation permalink)#1590lperson merged 19 commits intoProgressiveCoders:stage-main-62-wfpfrom
lperson merged 19 commits intoProgressiveCoders:stage-main-62-wfpfrom
Conversation
lperson
added
the
S-work in progress (WIP)
…in_message_review
…in_message_review
…into lp_tags_in_message_review
…in_message_review
lperson
removed
the
S-work in progress (WIP)
schuyler1d
approved these changes
Jun 9, 2020
Collaborator
schuyler1d
left a comment
schuyler1d
left a comment
There was a problem hiding this comment.
Awesome! I have a nit, but I'm going to merge this but can you follow-up with a change for it?
src/server/api/schema.js
Outdated
| { user }, | ||
| info | ||
| ) => { | ||
| const includeTags = graphqlInfo => { |
Collaborator
There was a problem hiding this comment.
Can this be moved somewhere and explain what it's for.
These root endpoints should be short and clear. Maybe info (maybe call it requestInfo or graphQLInfo) should just be passed to getConversations() and then includeTags can be a function in that library (and outside the function) rather than here?
lperson
changed the title
Collaborator
|
@lperson @schuyler1d after I deployed with this merged, and the build ran, app started crashing. I rolled back to previous build from last night. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Functionality dependent on EXPERIMENTAL_TAGS.
Tag filter added
Select tags to filter by
Tags display in message list
Selected tags display in the selector
Tags display in message preview (also note conversation permalink)
# Checklist: