828 fix max contacts #895
Merged
828 fix max contacts #895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shakalee14
approved these changes
Sep 11, 2018
Contributor
shakalee14
left a comment
shakalee14
left a comment
There was a problem hiding this comment.
Pulled this locally and tested - was able to successfully remove the ability for a texter from texting more contacts by setting MAX to 0. Was also able to set it to 10 afterwards to put them back in texting mode for the campaign.
shakalee14
added
the
S-ready for stage-main (qa)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can now set max contacts to 0 to stop texters in dynamic assignment mode from sending any more texts in that campaign. Before, we weren't distinguishing between 0 and null, so both meant no limit on contacts assigned to a given texter. This PR addresses #828 and the connected issue #629.
Note that we had to fix rethink-knex and bump it up a version, so ppl will have to update the node module to see changes working.