Invite links update #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
August 3, 2017 08:27
sreynen
requested review from
lady3bean,
mathemagica,
sandramchung,
schuyler1d and
shakalee14
shakalee14
reviewed
Aug 4, 2017
src/server/api/schema.js
Outdated
| @@ -1,3 +1,4 @@ | |||
| import { log } from '../../lib' | |||
Contributor
There was a problem hiding this comment.
Why are we importing log here? Are we using it/planning to use it in this file?
shakalee14
approved these changes
Aug 4, 2017
Contributor
|
I think we need to wrap the inviteInput in an array because of knex psql? Not sure if this is the same issue, but in order to do an insert statement and return the inserted id for knex and (specifically) psql, what you want to return needs to be wrapped in an array. But this comment could be completely un related. |
shakalee14
reviewed
Aug 4, 2017
Contributor
Author
|
Org creation should be fixed now. In my testing, the org I created doesn't get attached to my account, but I confirmed the org was created in the database, and I believe that also happens in master, so assuming it's not related to invite changes. |
lperson
added a commit
to lperson/Spoke
that referenced
this pull request
Jun 10, 2019
…_texter_status add suspended texter status
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For https://github.com/MoveOnOrg/Spoke/issues/86, this adds a hash column to the invite schema, populates it with UUID, and uses that instead of ID, so invite links are less guessable.