Skip to content

Feat/176/home#177

Merged
millkk04 merged 2 commits into
devfrom
feat/176/home
Feb 12, 2026
Merged

Feat/176/home#177
millkk04 merged 2 commits into
devfrom
feat/176/home

Conversation

@millkk04
Copy link
Copy Markdown
Collaborator

@millkk04 millkk04 commented Feb 12, 2026

Summary by CodeRabbit

  • New Features
    • Book recommendation cards now display category titles (e.g., author, genre, mood) for improved clarity and organization.
    • Enhanced popular book recommendations to explicitly categorize suggestions by type, providing better-structured discovery options.

@millkk04 millkk04 linked an issue Feb 12, 2026 that may be closed by this pull request
@millkk04 millkk04 requested a review from icarus0616 February 12, 2026 07:27
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Feb 12, 2026

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

Added a title field to the BookRecommendationCardResponse DTO and updated recommendation card generation methods to accept and propagate this parameter. Refactored popular books recommendation flow to explicitly construct author, genre, and mood sections with corresponding titles.

Changes

Cohort / File(s) Summary
DTO Enhancement
booklog/src/main/java/com/example/booklog/domain/onboarding/dto/BookRecommendationCardResponse.java
Added new title field (String) to store card category labels (e.g., "작가", "장르").
Service Signature Updates
booklog/src/main/java/com/example/booklog/domain/onboarding/service/OnboardingRecommendationService.java
Extended generateLibraryBasedCard and generateOnboardingBasedCard method signatures with String title parameter. Updated all call sites across three library sections and three onboarding sections to pass specific titles. Added new buildPopularBookCard helper method and refactored generatePopularBooksRecommendations to explicitly construct author/genre/mood sections with corresponding titles.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • feat: 목차 #160 — Modifies the same onboarding recommendation flow and BookRecommendationCardResponse DTO structure with related sectioned recommendations logic.

Suggested labels

enhancement

Suggested reviewers

  • jaehyeon4406

Poem

🐰 A title for each card, distinct and bright,
From 작가 to 분위기, set just right,
The service now passes its name with care,
Building recommendations with labels to share! ✨

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/176/home

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@millkk04 millkk04 merged commit 5ebfb0b into dev Feb 12, 2026
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEAT] 온보딩 수정

1 participant