Skip to content

Conversation

@VledicFranco
Copy link
Contributor

@VledicFranco VledicFranco commented Mar 29, 2021

Disclaimer: this PR sets up the il8n structure but does not contribute with an actual translation, the few French translations to titles are for proofing the setup is working.

Added support for il8n according Vuepress documentation: https://vuepress.vuejs.org/guide/i18n.html#site-level-i18n-config

This PR copy-pastes the english content into the 'fr' directory and translates some minor titles to show the il8n working.

To support more languages:

  1. edit the /src/.vuepress/config.js file (copy paste the french example and adapt)
    1.1) Here is a list of locales to help you find the one you need https://www.science.co.il/language/Locale-codes.php
  2. create a language directory inside the /src directory (e.g. '/src/es' for spanish)
  3. Copy all english content into the directory
  4. Optional: start translating the content inside the language directory

This solves #79 and enables #48

@mwojtera mwojtera self-requested a review March 31, 2021 08:45
@mwojtera mwojtera marked this pull request as draft March 31, 2021 08:46
@mwojtera mwojtera marked this pull request as ready for review March 31, 2021 08:46
@mwojtera mwojtera marked this pull request as draft March 31, 2021 08:46
@mwojtera
Copy link
Collaborator

There is no point in merging this into main until we have an actual translation present.

@fhilipk
Copy link
Contributor

fhilipk commented Mar 31, 2021

I'm working on one.

@eNapoles
Copy link
Contributor

eNapoles commented Apr 1, 2021

There is no point in merging this into main until we have an actual translation present.

Hello, I can take care of the Spanish translation. In fact, I have already translated the FAQ.

As it is such a long article, I divided it into two parts. You can find them here: I Part and II Part

@VledicFranco
Copy link
Contributor Author

VledicFranco commented Apr 1, 2021

It is not uncommon to show the english version while the content gets completely translated, I think there is value on merging this because it gives the structure for others to start contributing parts of the translations. It can be done by parts/steps.

Furthermore, I think @fhilipk told me you already had a french translation? you can merge it and then copy/paste the french translation within.

Also I am a developer, my contribution is to enable the translators, if you already have the french translation you can share it with me and I can add it to my PR, but I don't see much value on delaying a functional contribution

@VledicFranco
Copy link
Contributor Author

If you dont agree with me I would like to know what this needs to be merged. I spent part of my busy schedulle to make this contribution and would hate to see it trashed.

@fhilipk
Copy link
Contributor

fhilipk commented Apr 4, 2021

Cardinense would you have this in a doc - we use .md files it's hard to convert HTML to markdown

@eNapoles
Copy link
Contributor

eNapoles commented Apr 4, 2021

#82 (comment)

Cardinense would you have this in a doc - we use .md files it's hard to convert HTML to markdown

I don't have it in .doc, but I can do it (I'll upload it as soon as I finish, give me a few minutes)....

However, I would like to learn how to do it by my own means and become a permanent contributor (if there is no problem with that). I am not asking you to invest your time teaching me. Please, I only ask for a link to some content that tells me what I have to read and install to be able to translate the content. The learning and translation into Spanish is on me.

It took me a few hours, but I learned the basics of GitHub enough to install it on my PC along with VS Code, make a fork of this repository, fix some small markdown bugs and make a pool request. I don't know I need to learn something more. I really want to learn.

Regards.

Edit:
Catalyst FAQ translated to Spanish (.docx format): 1. FAQ Catalyst.docx

@mwojtera
Copy link
Collaborator

mwojtera commented Apr 5, 2021

If you dont agree with me I would like to know what this needs to be merged. I spent part of my busy schedulle to make this contribution and would hate to see it trashed.

Hi. Sorry for taking some time. Easter is family time and family takes priority. Regarding your work. Thank you for taking the effort, it will not be trashed, it just need some more effort. I don't think it's a good idea to just add a translation of the menu, when we don't have the actual translation. It's like picking up a book with a just translated cover, what will your first reaction be when you see it again? On TownHall or else? Underpromise and overdeliver, otherwise we will lose trust, that's my 3 cents.

@fhilipk If we indeed have a translation, then we need to add a commit with it and move this forward. If it's just a part like with @Cardinense Spanish FAQ, that's fine. Let's just put that into Spanish menu.

@FrancoAra @fhilipk @Cardinense
I think I have a compromise, regarding translation.

@FrancoAra Can you add a text in French on top of each page stating that we are looking for a translator and if the proposal gets funded this will be a part of the bounty system?

@Cardinense Could you do the same for Spanish? Minus the FAQ which is translated ofc.

@fhilipk What do you think?

@mwojtera
Copy link
Collaborator

mwojtera commented Apr 5, 2021

@Cardinense atm you need a basic knowledge of how to install and use node and npm. After that you need to know how to work with JSON and Markdown.

@FrancoAra has doing translations down so you could ask him if you have any doubts.

@VledicFranco
Copy link
Contributor Author

@mwojtera Thanks for you response, family is priority indeed :) I like the proposed compromise! I will update this hopefully this afternoon.

@Cardinense I can give you a hand with your setup! We can even schedule a 30min live session to help you, search for me at the #master-landing-page Discord channel of the Catalyst Discord. BTW I am a Spanish native speaker, so feel free to speak in Spanish with me as well if you want :)

@eNapoles
Copy link
Contributor

eNapoles commented Apr 6, 2021

@FrancoAra

I am a Spanish native speaker

You don't know how glad I am to hear that. That's great!

We can even schedule a 30min live session to help you, search for me at the #master-landing-page Discord channel of the Catalyst Discord

Just tell me when

I can give you a hand with your setup!

That's exactly what I need! I would be VERY grateful.

EDIT:

@mwojtera

FrancoAra: Can you add a text in French on top of each page stating that we are looking for a translator and if the proposal gets funded this will be a part of the bounty system?
Cardinense: Could you do the same for Spanish? Minus the FAQ which is translated ofc.

I will do so. I don't want to slow the project down with my learning about GitHub and npm. However, if I manage to catch up with @FrancoAra's help, I would like to stay as Spanish translator.

Cardinense: atm you need a basic knowledge of how to install and use node and npm. After that you need to know how to work with JSON and Markdown.

I have been working on it since yesterday. Thank you!

@fhilipk
Copy link
Contributor

fhilipk commented Apr 7, 2021

That's exactly what I need! I would be VERY grateful.
You can find the discord here: https://discord.gg/HkrCprGHqY

You can start by learning markdown https://www.markdownguide.org/
It's designed so people can create simple content for websites and it's converted into HTML.

There are converter to change doc to markdown (if you search for this you will find) they do a good job but usually need some work or at least a look over to make sure it works. You just save the file as xyz.md instead of xyz.docx and we can use it.

Thank you so much for helping with this project.

@VledicFranco
Copy link
Contributor Author

@mwojtera @fhilipk @Cardinense I changed the setup from French to Spanish, so to start integrating @Cardinense 's translations. Also I added the "Estamos buscando traductores, si te interesa contribuir visita la página de GitHub" which means "we are looking for translators, if interested visit the Githuib page" to each page

@VledicFranco VledicFranco marked this pull request as ready for review April 7, 2021 19:56
@VledicFranco
Copy link
Contributor Author

As a note, Cardinense and I are in contact, and he is learning really fast!

Copy link
Collaborator

@mwojtera mwojtera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good result. However it would be good to:

  1. Add information about translation on the main page
  2. There is problem with /es/funds/ CSS in the CountdownTimer needs to be scoped. src/.vuepress/components/CountdownTimer.vue
    <style> needs to be changed to <style scoped> would be best if you could do it in your request, so we don't create a whole new process of branch, pull request + review

@VledicFranco
Copy link
Contributor Author

May I request this to be merged and then subsequent fixes/improvements on subsequent PRs?

…ws scroll on es page. Fixed styles in countdown timer
@mwojtera mwojtera self-requested a review April 9, 2021 17:53
@mwojtera mwojtera merged commit cb915c4 into Project-Catalyst:main Apr 9, 2021
@VledicFranco
Copy link
Contributor Author

yaaay much appreciated! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants