-
Notifications
You must be signed in to change notification settings - Fork 16
Added support for il8n #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There is no point in merging this into main until we have an actual translation present. |
|
I'm working on one. |
|
It is not uncommon to show the english version while the content gets completely translated, I think there is value on merging this because it gives the structure for others to start contributing parts of the translations. It can be done by parts/steps. Furthermore, I think @fhilipk told me you already had a french translation? you can merge it and then copy/paste the french translation within. Also I am a developer, my contribution is to enable the translators, if you already have the french translation you can share it with me and I can add it to my PR, but I don't see much value on delaying a functional contribution |
|
If you dont agree with me I would like to know what this needs to be merged. I spent part of my busy schedulle to make this contribution and would hate to see it trashed. |
|
Cardinense would you have this in a doc - we use .md files it's hard to convert HTML to markdown |
I don't have it in .doc, but I can do it (I'll upload it as soon as I finish, give me a few minutes).... However, I would like to learn how to do it by my own means and become a permanent contributor (if there is no problem with that). I am not asking you to invest your time teaching me. Please, I only ask for a link to some content that tells me what I have to read and install to be able to translate the content. The learning and translation into Spanish is on me. It took me a few hours, but I learned the basics of GitHub enough to install it on my PC along with VS Code, make a fork of this repository, fix some small markdown bugs and make a pool request. I don't know I need to learn something more. I really want to learn. Regards. Edit: |
Hi. Sorry for taking some time. Easter is family time and family takes priority. Regarding your work. Thank you for taking the effort, it will not be trashed, it just need some more effort. I don't think it's a good idea to just add a translation of the menu, when we don't have the actual translation. It's like picking up a book with a just translated cover, what will your first reaction be when you see it again? On TownHall or else? Underpromise and overdeliver, otherwise we will lose trust, that's my 3 cents. @fhilipk If we indeed have a translation, then we need to add a commit with it and move this forward. If it's just a part like with @Cardinense Spanish FAQ, that's fine. Let's just put that into Spanish menu. @FrancoAra @fhilipk @Cardinense @FrancoAra Can you add a text in French on top of each page stating that we are looking for a translator and if the proposal gets funded this will be a part of the bounty system? @Cardinense Could you do the same for Spanish? Minus the FAQ which is translated ofc. @fhilipk What do you think? |
|
@Cardinense atm you need a basic knowledge of how to install and use node and npm. After that you need to know how to work with JSON and Markdown. @FrancoAra has doing translations down so you could ask him if you have any doubts. |
|
@mwojtera Thanks for you response, family is priority indeed :) I like the proposed compromise! I will update this hopefully this afternoon. @Cardinense I can give you a hand with your setup! We can even schedule a 30min live session to help you, search for me at the #master-landing-page Discord channel of the Catalyst Discord. BTW I am a Spanish native speaker, so feel free to speak in Spanish with me as well if you want :) |
|
@FrancoAra
You don't know how glad I am to hear that. That's great!
Just tell me when
That's exactly what I need! I would be VERY grateful. EDIT:
I will do so. I don't want to slow the project down with my learning about GitHub and npm. However, if I manage to catch up with @FrancoAra's help, I would like to stay as Spanish translator.
I have been working on it since yesterday. Thank you! |
You can start by learning markdown https://www.markdownguide.org/ There are converter to change doc to markdown (if you search for this you will find) they do a good job but usually need some work or at least a look over to make sure it works. You just save the file as xyz.md instead of xyz.docx and we can use it. Thank you so much for helping with this project. |
|
@mwojtera @fhilipk @Cardinense I changed the setup from French to Spanish, so to start integrating @Cardinense 's translations. Also I added the "Estamos buscando traductores, si te interesa contribuir visita la página de GitHub" which means "we are looking for translators, if interested visit the Githuib page" to each page |
|
As a note, Cardinense and I are in contact, and he is learning really fast! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall good result. However it would be good to:
- Add information about translation on the main page
- There is problem with /es/funds/ CSS in the CountdownTimer needs to be scoped. src/.vuepress/components/CountdownTimer.vue
<style>needs to be changed to<style scoped>would be best if you could do it in your request, so we don't create a whole new process of branch, pull request + review
|
May I request this to be merged and then subsequent fixes/improvements on subsequent PRs? |
…ws scroll on es page. Fixed styles in countdown timer
|
yaaay much appreciated! :D |
Disclaimer: this PR sets up the il8n structure but does not contribute with an actual translation, the few French translations to titles are for proofing the setup is working.
Added support for il8n according Vuepress documentation: https://vuepress.vuejs.org/guide/i18n.html#site-level-i18n-config
This PR copy-pastes the english content into the 'fr' directory and translates some minor titles to show the il8n working.
To support more languages:
1.1) Here is a list of locales to help you find the one you need https://www.science.co.il/language/Locale-codes.php
This solves #79 and enables #48