Skip to content

Fix/mascot download static serving#205

Merged
yyuneu merged 4 commits into
developfrom
fix/mascot-download-static-serving
Jun 10, 2026
Merged

Fix/mascot download static serving#205
yyuneu merged 4 commits into
developfrom
fix/mascot-download-static-serving

Conversation

@yyuneu

@yyuneu yyuneu commented Jun 10, 2026

Copy link
Copy Markdown
Member

Summary

Tasks

  • deploy/nginx.conf.template/internal/files/ location을 alias /srv/files/ + sendfile로 교체, GLB/PDF/이미지 MIME type 명시, Accept-Ranges 헤더 추가
  • deploy/docker-compose.prod.yml — nginx 서비스에 uploads:/srv/files:ro 볼륨 추가

To Reviewer

  • Java 코드(FileDownloadController) 변경 없음. 로컬 dev 환경(FILE_BASE_URL=localhost:8081)에서는 기존대로 JVM이 서빙. prod에서만 nginx가 location을 먼저 가로채서 JVM
    미경유.
  • alias + location 끝 슬래시 정합성 확인: /internal/files//srv/files/ 매핑 정확함.
  • autoindex 기본 off이므로 디렉터리 목록 노출 없음. 해당 파일들은 기존에도 무인증 공개 서빙이라 보안 회귀 없음.

Screenshot

@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c87eb937-8c5b-4ddd-8e3f-0f1a68937b18

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/mascot-download-static-serving

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@yyuneu yyuneu merged commit 8f7ba76 into develop Jun 10, 2026
2 checks passed
@yyuneu yyuneu deleted the fix/mascot-download-static-serving branch June 10, 2026 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant