Skip to content

fix EncodePodSingleDevice method#178

Merged
archlitchi merged 1 commit intoProject-HAMi:masterfrom
lengrongfu:fix/pod-device-coding
Mar 11, 2024
Merged

fix EncodePodSingleDevice method#178
archlitchi merged 1 commit intoProject-HAMi:masterfrom
lengrongfu:fix/pod-device-coding

Conversation

@lengrongfu
Copy link
Member

@lengrongfu lengrongfu commented Mar 11, 2024

fix EncodePodSingleDevice method, when one pod having more then one container use device, this method encode device string will error.

  • add many case to run unit tests.
  • fix this bug.
  • use const OneContainerMultiDeviceSplitSymbol and OnePodMultiContainerSplitSymbol to replace hardcode.

Signed-off-by: rongfu.leng <lenronfu@gmail.com>
@lengrongfu
Copy link
Member Author

lengrongfu commented Mar 11, 2024

cc @archlitchi Please help to check this pr

@archlitchi
Copy link
Member

thanks for fixing this issue:)

@archlitchi archlitchi merged commit 5c4fa9b into Project-HAMi:master Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants