add lint script & fix code that fails static checking#225
Merged
wawa0210 merged 1 commit intoProject-HAMi:masterfrom Mar 27, 2024
Merged
add lint script & fix code that fails static checking#225wawa0210 merged 1 commit intoProject-HAMi:masterfrom
wawa0210 merged 1 commit intoProject-HAMi:masterfrom
Conversation
CoderTH
force-pushed
the
add-ci-lint
branch
28 times, most recently
from
8e41263 to
c98cae3
Compare
Contributor
Author
|
@archlitchi @lengrongfu @chaunceyjiang @calvin0327 @wawa0210 cc I have added ci action for static checking and have been able to work properly, but I have only opened part of the linter. Because of the code history, there are many static checking errors. These bug fixes may affect the existing logic. I suggest that projects such as E2e test have relatively perfect unit tests and open them again after e2e check. Please help review. |
Member
|
/lgtm |
wawa0210
reviewed
Mar 25, 2024
CoderTH
force-pushed
the
add-ci-lint
branch
3 times, most recently
from
946893f to
b4a2c00
Compare
Signed-off-by: coderth <coderth@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a script for static checking and fix static check errors in the code