fix: correct technical errors in configure, ascend, prerequisites, and webui docs#327
Open
mesutoezdil wants to merge 2 commits intoProject-HAMi:masterfrom
Open
fix: correct technical errors in configure, ascend, prerequisites, and webui docs#327mesutoezdil wants to merge 2 commits intoProject-HAMi:masterfrom
mesutoezdil wants to merge 2 commits intoProject-HAMi:masterfrom
Conversation
…d webui docs - configure.md: fix nvidia.resourceCoreName default value from nvidia.com/cores to nvidia.com/gpucores across docs and all versioned snapshots (v2.5.1, v2.6.0, v2.7.0, v2.8.0) - enable-ascend-sharing.md: fix two typos in notes section: Ascend91B0 -> Ascend910B and huawe.com -> huawei.com across docs and all versioned snapshots (v1.3.0, v2.4.1, v2.5.0, v2.5.1, v2.6.0, v2.7.0, v2.8.0) - prerequisites.md: add missing sudo before systemctl restart docker in all versioned snapshots (v1.3.0, v2.4.1, v2.5.0, v2.5.1, v2.6.0, v2.7.0, v2.8.0) - webui-installation.md: fix namespace inconsistency in troubleshooting and uninstall sections (hami -> kube-system to match install command) Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mesutoezdil The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for project-hami ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Keep namespace fix (kube-system) aligned with install command, incorporate upstream phrasing improvements to uninstall section. Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
configure.md:nvidia.resourceCoreNamedefault was documented asnvidia.com/coresbut every example and usage in the codebase usesnvidia.com/gpucores- corrected across docs and versioned snapshots v2.5.1, v2.6.0, v2.7.0, v2.8.0enable-ascend-sharing.md: two typos in the Notes section -Ascend91B0(missing digit1) corrected toAscend910B, andhuawe.com(missing letteri) corrected tohuawei.com- applied across docs and versioned snapshots v1.3.0, v2.4.1, v2.5.0, v2.5.1, v2.6.0, v2.7.0, v2.8.0prerequisites.md:systemctl restart dockerwas missingsudoin all versioned snapshots (v1.3.0, v2.4.1, v2.5.0, v2.5.1, v2.6.0, v2.7.0, v2.8.0) - thedocs/version was already correctwebui-installation.md: troubleshooting and uninstall sections referencedhaminamespace but the install command uses-n kube-system- aligned tokube-system