Skip to content

Conversation

@Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Jul 5, 2021

Fixes #2516 .

Description

This PR changed the outdated source code link of PyTorch and ignite to the formal API docs.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Nic-Ma added 2 commits July 5, 2021 10:11
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma Nic-Ma marked this pull request as ready for review July 5, 2021 02:53
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Jul 5, 2021

/black

Signed-off-by: Nic Ma <nma@nvidia.com>
Copy link
Contributor

@yiheng-wang-nv yiheng-wang-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it's really helpful.

@Nic-Ma Nic-Ma enabled auto-merge (squash) July 5, 2021 03:51
@Nic-Ma Nic-Ma merged commit 42a1125 into dev Jul 5, 2021
@Nic-Ma Nic-Ma deleted the 2516-fix-reference-links branch July 5, 2021 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PyTorch and ignite reference links are outdated

3 participants